You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Sumit Mohanty <sm...@hortonworks.com> on 2015/05/13 03:16:43 UTC

Review Request 34146: Auto recovery commands should not be scheduled till the execution commands are complete

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34146/
-----------------------------------------------------------

Review request for Ambari, Alejandro Fernandez, Ivan Mitic, Mahadev Konar, and Sid Wagle.


Bugs: AMBARI-11089
    https://issues.apache.org/jira/browse/AMBARI-11089


Repository: ambari


Description
-------

Auto recovery commands should not be scheduled till the execution commands are complete


Diffs
-----

  ambari-agent/src/main/python/ambari_agent/ActionQueue.py bdaefd0 
  ambari-agent/src/main/python/ambari_agent/CommandStatusDict.py 0ebc45e 
  ambari-agent/src/main/python/ambari_agent/Controller.py 9ebb83a 
  ambari-agent/src/test/python/ambari_agent/TestActionQueue.py ee18c38 

Diff: https://reviews.apache.org/r/34146/diff/


Testing
-------

agent unit tests pass.
Manually tested with start all component and then killing some component processes.


Thanks,

Sumit Mohanty


Re: Review Request 34146: Auto recovery commands should not be scheduled till the execution commands are complete

Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34146/#review83543
-----------------------------------------------------------

Ship it!


Ship It!

- Alejandro Fernandez


On May 13, 2015, 1:16 a.m., Sumit Mohanty wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34146/
> -----------------------------------------------------------
> 
> (Updated May 13, 2015, 1:16 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Ivan Mitic, Mahadev Konar, and Sid Wagle.
> 
> 
> Bugs: AMBARI-11089
>     https://issues.apache.org/jira/browse/AMBARI-11089
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Auto recovery commands should not be scheduled till the execution commands are complete
> 
> 
> Diffs
> -----
> 
>   ambari-agent/src/main/python/ambari_agent/ActionQueue.py bdaefd0 
>   ambari-agent/src/main/python/ambari_agent/CommandStatusDict.py 0ebc45e 
>   ambari-agent/src/main/python/ambari_agent/Controller.py 9ebb83a 
>   ambari-agent/src/test/python/ambari_agent/TestActionQueue.py ee18c38 
> 
> Diff: https://reviews.apache.org/r/34146/diff/
> 
> 
> Testing
> -------
> 
> agent unit tests pass.
> Manually tested with start all component and then killing some component processes.
> 
> 
> Thanks,
> 
> Sumit Mohanty
> 
>


Re: Review Request 34146: Auto recovery commands should not be scheduled till the execution commands are complete

Posted by Mahadev Konar <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34146/#review83542
-----------------------------------------------------------

Ship it!


Ship It!

- Mahadev Konar


On May 13, 2015, 1:16 a.m., Sumit Mohanty wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34146/
> -----------------------------------------------------------
> 
> (Updated May 13, 2015, 1:16 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Ivan Mitic, Mahadev Konar, and Sid Wagle.
> 
> 
> Bugs: AMBARI-11089
>     https://issues.apache.org/jira/browse/AMBARI-11089
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Auto recovery commands should not be scheduled till the execution commands are complete
> 
> 
> Diffs
> -----
> 
>   ambari-agent/src/main/python/ambari_agent/ActionQueue.py bdaefd0 
>   ambari-agent/src/main/python/ambari_agent/CommandStatusDict.py 0ebc45e 
>   ambari-agent/src/main/python/ambari_agent/Controller.py 9ebb83a 
>   ambari-agent/src/test/python/ambari_agent/TestActionQueue.py ee18c38 
> 
> Diff: https://reviews.apache.org/r/34146/diff/
> 
> 
> Testing
> -------
> 
> agent unit tests pass.
> Manually tested with start all component and then killing some component processes.
> 
> 
> Thanks,
> 
> Sumit Mohanty
> 
>


Re: Review Request 34146: Auto recovery commands should not be scheduled till the execution commands are complete

Posted by Sumit Mohanty <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34146/
-----------------------------------------------------------

(Updated May 13, 2015, 2:43 a.m.)


Review request for Ambari, Alejandro Fernandez, Ivan Mitic, Mahadev Konar, and Sid Wagle.


Changes
-------

Modified the code a bit to keep track of executing commands.


Bugs: AMBARI-11089
    https://issues.apache.org/jira/browse/AMBARI-11089


Repository: ambari


Description
-------

Auto recovery commands should not be scheduled till the execution commands are complete


Diffs (updated)
-----

  ambari-agent/src/main/python/ambari_agent/ActionQueue.py bdaefd0 
  ambari-agent/src/main/python/ambari_agent/CommandStatusDict.py 0ebc45e 
  ambari-agent/src/main/python/ambari_agent/Controller.py 9ebb83a 
  ambari-agent/src/main/python/ambari_agent/RecoveryManager.py e2c5e98 
  ambari-agent/src/test/python/ambari_agent/TestActionQueue.py ee18c38 
  ambari-agent/src/test/python/ambari_agent/TestRecoveryManager.py bd7c96b 

Diff: https://reviews.apache.org/r/34146/diff/


Testing
-------

agent unit tests pass.
Manually tested with start all component and then killing some component processes.


Thanks,

Sumit Mohanty