[GitHub] [airflow] ashb commented on a diff in pull request #23222: Fix X-Frame enabled behaviour

[GitBox <gi...@apache.org>]

ashb commented on code in PR #23222:
URL: https://github.com/apache/airflow/pull/23222#discussion_r857935241


##########
airflow/www/extensions/init_security.py:
##########
@@ -31,12 +31,11 @@ def init_xframe_protection(app):
     See also: https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/X-Frame-Options
     """
     x_frame_enabled = conf.getboolean('webserver', 'X_FRAME_ENABLED', fallback=True)
-    if not x_frame_enabled:
+    if x_frame_enabled:
         return

Review Comment:
   Hmmmm, does "correcting" this now end up breaking things I wonder?
   
   i.e. do we follow the what our docs say, or do we update the docs to match what the implementation currently does?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org