You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@grails.apache.org by "jdaugherty (via GitHub)" <gi...@apache.org> on 2025/05/16 14:53:11 UTC
[PR] Switch back to 3.4.3 to fix nested jar file loading until 3.5.0 is out with the spring framework 6.2.7. [grails-core]
jdaugherty opened a new pull request, #14747:
URL: https://github.com/apache/grails-core/pull/14747
Merging the dependency downgrade from https://github.com/apache/grails-core/pull/14745 to make sure the tests work as expected in that PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Switch back to 3.4.3 to fix nested jar file loading until 3.5.0 is out with the spring framework 6.2.7. [grails-core]
Posted by "jdaugherty (via GitHub)" <gi...@apache.org>.
jdaugherty merged PR #14747:
URL: https://github.com/apache/grails-core/pull/14747
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Switch back to 3.4.3 to fix nested jar file loading until 3.5.0 is out with the spring framework 6.2.7. [grails-core]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #14747:
URL: https://github.com/apache/grails-core/pull/14747#discussion_r2093212876
##########
dependencies.gradle:
##########
@@ -44,7 +42,8 @@ ext {
'objenesis.version' : '3.4',
'gradle-spock.version' : '2.3-groovy-3.0',
'gradle-nexus-publish-plugin.version': '2.0.0',
- 'spring-boot.version' : '3.5.0-RC1',
+ // 3.4.4 to 3.5.0-RC1 has https://github.com/spring-projects/spring-framework/issues/34796 which prevents running apps via jar (nested jar failures)
Review Comment:
[nitpick] The comment indicates that versions 3.4.4 to 3.5.0-RC1 have issues with nested jar loading, but the dependency is downgraded to 3.4.3. Consider updating the comment to clearly explain why 3.4.3 is chosen, ensuring consistency between the comment and the version set.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Switch back to 3.4.3 to fix nested jar file loading until 3.5.0 is out with the spring framework 6.2.7. [grails-core]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #14747:
URL: https://github.com/apache/grails-core/pull/14747#discussion_r2093212876
##########
dependencies.gradle:
##########
@@ -44,7 +42,8 @@ ext {
'objenesis.version' : '3.4',
'gradle-spock.version' : '2.3-groovy-3.0',
'gradle-nexus-publish-plugin.version': '2.0.0',
- 'spring-boot.version' : '3.5.0-RC1',
+ // 3.4.4 to 3.5.0-RC1 has https://github.com/spring-projects/spring-framework/issues/34796 which prevents running apps via jar (nested jar failures)
Review Comment:
[nitpick] The comment indicates that versions 3.4.4 to 3.5.0-RC1 have issues with nested jar loading, but the dependency is downgraded to 3.4.3. Consider updating the comment to clearly explain why 3.4.3 is chosen, ensuring consistency between the comment and the version set.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org