You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Kurt Deschler (Code Review)" <ge...@cloudera.org> on 2023/05/09 14:25:49 UTC

[Impala-ASF-CR] IMPALA-12129: Fix elapsed time calculation in query timeline

Kurt Deschler has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19864


Change subject: IMPALA-12129: Fix elapsed time calculation in query timeline
......................................................................

IMPALA-12129: Fix elapsed time calculation in query timeline

This patch fixes handling of running queries in the query timeline. An
additional check was added to skip JSON sections that are not available
while the query is running. The page refresh was changed to wait until
End Time is set since Query State can be set to FINISHED for running
queries.

Testing: Manually tested query in WebUI

Change-Id: I5a426008addc49183af1b317164d5b02d5f8ceec
---
M www/query_timeline.tmpl
1 file changed, 5 insertions(+), 5 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/64/19864/1
-- 
To view, visit http://gerrit.cloudera.org:8080/19864
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5a426008addc49183af1b317164d5b02d5f8ceec
Gerrit-Change-Number: 19864
Gerrit-PatchSet: 1
Gerrit-Owner: Kurt Deschler <kd...@cloudera.com>

[Impala-ASF-CR] IMPALA-12129: Handle running queries in query timeline

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19864 )

Change subject: IMPALA-12129: Handle running queries in query timeline
......................................................................


Patch Set 3:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/12984/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/19864
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5a426008addc49183af1b317164d5b02d5f8ceec
Gerrit-Change-Number: 19864
Gerrit-PatchSet: 3
Gerrit-Owner: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Surya Hebbar <sh...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Tue, 09 May 2023 22:52:29 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12129: Fix elapsed time calculation in query timeline

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19864 )

Change subject: IMPALA-12129: Fix elapsed time calculation in query timeline
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/19864
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5a426008addc49183af1b317164d5b02d5f8ceec
Gerrit-Change-Number: 19864
Gerrit-PatchSet: 2
Gerrit-Owner: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Surya Hebbar <sh...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Tue, 09 May 2023 18:23:17 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12129: Handle running queries in query timeline

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19864 )

Change subject: IMPALA-12129: Handle running queries in query timeline
......................................................................


Patch Set 4: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/19864
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5a426008addc49183af1b317164d5b02d5f8ceec
Gerrit-Change-Number: 19864
Gerrit-PatchSet: 4
Gerrit-Owner: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Surya Hebbar <sh...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Wed, 10 May 2023 04:06:30 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12129: Handle running queries in query timeline

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19864 )

Change subject: IMPALA-12129: Handle running queries in query timeline
......................................................................

IMPALA-12129: Handle running queries in query timeline

This patch fixes handling of running queries in the query timeline. An
additional check was added to skip JSON sections that are not available
while the query is running. The page refresh was changed to wait until
End Time is set since Query State can be set to FINISHED for running
queries.

Testing: Manually tested query in WebUI

Change-Id: I5a426008addc49183af1b317164d5b02d5f8ceec
Reviewed-on: http://gerrit.cloudera.org:8080/19864
Reviewed-by: Wenzhe Zhou <wz...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M www/query_timeline.tmpl
1 file changed, 5 insertions(+), 5 deletions(-)

Approvals:
  Wenzhe Zhou: Looks good to me, approved
  Impala Public Jenkins: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/19864
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I5a426008addc49183af1b317164d5b02d5f8ceec
Gerrit-Change-Number: 19864
Gerrit-PatchSet: 5
Gerrit-Owner: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Surya Hebbar <sh...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>

[Impala-ASF-CR] IMPALA-12129: Fix elapsed time calculation in query timeline

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19864 )

Change subject: IMPALA-12129: Fix elapsed time calculation in query timeline
......................................................................


Patch Set 2:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9299/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/19864
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5a426008addc49183af1b317164d5b02d5f8ceec
Gerrit-Change-Number: 19864
Gerrit-PatchSet: 2
Gerrit-Owner: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Surya Hebbar <sh...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Tue, 09 May 2023 18:23:18 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12129: Fix elapsed time calculation in query timeline

Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/19864 )

Change subject: IMPALA-12129: Fix elapsed time calculation in query timeline
......................................................................


Patch Set 1: Code-Review+2

Verified on local machine for the patch. It works as expected.


-- 
To view, visit http://gerrit.cloudera.org:8080/19864
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5a426008addc49183af1b317164d5b02d5f8ceec
Gerrit-Change-Number: 19864
Gerrit-PatchSet: 1
Gerrit-Owner: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Surya Hebbar <sh...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Tue, 09 May 2023 18:22:16 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12129: Handle running queries in query timeline

Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/19864 )

Change subject: IMPALA-12129: Handle running queries in query timeline
......................................................................


Patch Set 4: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/19864
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5a426008addc49183af1b317164d5b02d5f8ceec
Gerrit-Change-Number: 19864
Gerrit-PatchSet: 4
Gerrit-Owner: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Surya Hebbar <sh...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Tue, 09 May 2023 23:02:02 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12129: Fix elapsed time calculation in query timeline

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19864 )

Change subject: IMPALA-12129: Fix elapsed time calculation in query timeline
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/12972/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/19864
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5a426008addc49183af1b317164d5b02d5f8ceec
Gerrit-Change-Number: 19864
Gerrit-PatchSet: 1
Gerrit-Owner: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Surya Hebbar <sh...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Tue, 09 May 2023 14:47:14 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12129: Handle running queries in query timeline

Posted by "Kurt Deschler (Code Review)" <ge...@cloudera.org>.
Hello Surya Hebbar, Wenzhe Zhou, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/19864

to look at the new patch set (#3).

Change subject: IMPALA-12129: Handle running queries in query timeline
......................................................................

IMPALA-12129: Handle running queries in query timeline

This patch fixes handling of running queries in the query timeline. An
additional check was added to skip JSON sections that are not available
while the query is running. The page refresh was changed to wait until
End Time is set since Query State can be set to FINISHED for running
queries.

Testing: Manually tested query in WebUI

Change-Id: I5a426008addc49183af1b317164d5b02d5f8ceec
---
M www/query_timeline.tmpl
1 file changed, 5 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/64/19864/3
-- 
To view, visit http://gerrit.cloudera.org:8080/19864
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5a426008addc49183af1b317164d5b02d5f8ceec
Gerrit-Change-Number: 19864
Gerrit-PatchSet: 3
Gerrit-Owner: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Surya Hebbar <sh...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>

[Impala-ASF-CR] IMPALA-12129: Handle running queries in query timeline

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19864 )

Change subject: IMPALA-12129: Handle running queries in query timeline
......................................................................


Patch Set 4:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9300/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/19864
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5a426008addc49183af1b317164d5b02d5f8ceec
Gerrit-Change-Number: 19864
Gerrit-PatchSet: 4
Gerrit-Owner: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Surya Hebbar <sh...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Tue, 09 May 2023 22:51:58 +0000
Gerrit-HasComments: No