You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by ap...@apache.org on 2022/05/31 19:45:53 UTC

[hbase] 01/02: HBASE-27068 NPE occurs when the active master has not yet been elected (#4474)

This is an automated email from the ASF dual-hosted git repository.

apurtell pushed a commit to branch branch-2
in repository https://gitbox.apache.org/repos/asf/hbase.git

commit f4f3e63f9f41def60d8d272aa68c262220022be4
Author: litao <to...@gmail.com>
AuthorDate: Wed Jun 1 02:49:49 2022 +0800

    HBASE-27068 NPE occurs when the active master has not yet been elected (#4474)
    
    Signed-off-by: Pankaj Kumar <pa...@apache.org>
    Signed-off-by: Viraj Jasani<virajjasani@apache.org
---
 .../org/apache/hadoop/hbase/tmpl/master/BackupMasterStatusTmpl.jamon | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/BackupMasterStatusTmpl.jamon b/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/BackupMasterStatusTmpl.jamon
index 190f1dd857..21af264bbe 100644
--- a/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/BackupMasterStatusTmpl.jamon
+++ b/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/BackupMasterStatusTmpl.jamon
@@ -24,12 +24,13 @@ java.util.*;
 org.apache.hadoop.hbase.ServerName;
 org.apache.hadoop.hbase.ClusterMetrics;
 org.apache.hadoop.hbase.master.HMaster;
+org.apache.hbase.thirdparty.com.google.common.base.Preconditions;
 </%import>
 <%if (!master.isActiveMaster()) %>
     <%java>
     ServerName active_master = master.getActiveMaster().orElse(null);
-    assert active_master != null : "Failed to retrieve active master's ServerName!";
-    int activeInfoPort = active_master == null ? 0 : master.getActiveMasterInfoPort();
+    Preconditions.checkState(active_master != null, "Failed to retrieve active master's ServerName!");
+    int activeInfoPort = master.getActiveMasterInfoPort();
     </%java>
     <div class="row inner_header">
         <div class="page-header">