You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/03/30 17:55:27 UTC
[GitHub] [superset] codemaster08240328 opened a new pull request #19444: fix: Error Message is cut off in alerts & reports log page
codemaster08240328 opened a new pull request #19444:
URL: https://github.com/apache/superset/pull/19444
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
Before:
<img width="1315" alt="image" src="https://user-images.githubusercontent.com/39701522/160899714-96561535-d196-4f6d-8ab7-db2e824da958.png">
### TESTING INSTRUCTIONS
1. Go to reports & alerts log page.
2. Check Error Message.
3. It should be wrapped by tooltip.
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [x] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #19444: fix: Error Message is cut off in alerts & reports log page
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #19444:
URL: https://github.com/apache/superset/pull/19444#issuecomment-1083480387
# [Codecov](https://codecov.io/gh/apache/superset/pull/19444?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#19444](https://codecov.io/gh/apache/superset/pull/19444?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b4eb2c5) into [master](https://codecov.io/gh/apache/superset/commit/a4c261d72c3f2c26d443cb202fb79d168fab6c93?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a4c261d) will **decrease** coverage by `0.00%`.
> The diff coverage is `50.00%`.
```diff
@@ Coverage Diff @@
## master #19444 +/- ##
==========================================
- Coverage 66.59% 66.59% -0.01%
==========================================
Files 1670 1670
Lines 63888 63890 +2
Branches 6510 6511 +1
==========================================
+ Hits 42544 42545 +1
- Misses 19655 19656 +1
Partials 1689 1689
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `51.33% <50.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/19444?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...set-frontend/src/views/CRUD/alert/ExecutionLog.tsx](https://codecov.io/gh/apache/superset/pull/19444/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvRXhlY3V0aW9uTG9nLnRzeA==) | `80.95% <50.00%> (-3.26%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/19444?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/19444?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a4c261d...b4eb2c5](https://codecov.io/gh/apache/superset/pull/19444?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codemaster08240328 commented on a change in pull request #19444: fix: Error Message is cut off in alerts & reports log page
Posted by GitBox <gi...@apache.org>.
codemaster08240328 commented on a change in pull request #19444:
URL: https://github.com/apache/superset/pull/19444#discussion_r840552952
##########
File path: superset-frontend/src/views/CRUD/alert/ExecutionLog.tsx
##########
@@ -144,6 +145,15 @@ function ExecutionLog({ addDangerToast, isReportEnabled }: ExecutionLogProps) {
{
accessor: 'error_message',
Header: t('Error message'),
+ Cell: ({
+ row: {
Review comment:
Yes, @diegomedina248 , all rows have the nested object which contains `original`.
We can confirm this from line# 133. (https://github.com/apache/superset/pull/19444/files#diff-b0502ccd40e521f12fa41224e8486ad60145cbccb955f2122c1a4da6f5904081R133)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] diegomedina248 commented on a change in pull request #19444: fix: Error Message is cut off in alerts & reports log page
Posted by GitBox <gi...@apache.org>.
diegomedina248 commented on a change in pull request #19444:
URL: https://github.com/apache/superset/pull/19444#discussion_r838935323
##########
File path: superset-frontend/src/views/CRUD/alert/ExecutionLog.tsx
##########
@@ -144,6 +145,15 @@ function ExecutionLog({ addDangerToast, isReportEnabled }: ExecutionLogProps) {
{
accessor: 'error_message',
Header: t('Error message'),
+ Cell: ({
+ row: {
Review comment:
are you sure all rows are objects that have an `original` nested object?
If not, this could fail, and maybe we need to use optional chaining instead
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org