You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "dkranchii (via GitHub)" <gi...@apache.org> on 2026/09/25 00:49:13 UTC
[PR] API: Remove stale TODO in VariantTestUtil.createArray [iceberg]
dkranchii opened a new pull request, #18253:
URL: https://github.com/apache/iceberg/pull/18253
Closes #17510.
`VariantTestUtil.createArray` carries a TODO asking for a way to size variant
elements without serializing them. That capability already exists.
`VariantValue.sizeInBytes()` is contractually the serialized size, and no
implementation produces bytes to report it: `SerializedValue` returns
`buffer().remaining()` and its `writeTo` copies exactly that buffer; `ValueArray`
and `ShreddedObject` delegate to `SerializationState.size()`, which is arithmetic
over the recursive sum of element sizes; `PrimitiveWrapper` is a switch over
constants. `ValueArray` and `ShreddedObject` also share one cached
`SerializationState` between `size()` and `writeTo()`, so the
`sizeInBytes()`-then-`writeTo()` sequence in `createArray` builds that state once.
The TODO predates `SerializationState`, so this removes it. `createObject` uses the
same loop and is correct for the same reasons.
Test plan: no new tests, comment-only change. The concern in the issue, that an
embedded `SerializedArray` may not report the size it needs inside a parent, is
already covered by `TestSerializedArray.testArrayOfMixedTypes`, which nests a
`SerializedArray` in a `createArray` parent and reads every element back.
`TestShreddedObject.testWriteToDisagreesWithSizeInBytes` separately enforces that
`writeTo` must agree with `sizeInBytes()`.
---
**AI Disclosure**
- Platform/Tool: Cursor
- Prompt Summary: Investigate issue #17510 on computing variant element sizes in VariantTestUtil and implement the change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] API: Remove stale TODO in VariantTestUtil.createArray [iceberg]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #18253:
URL: https://github.com/apache/iceberg/pull/18253#issuecomment-6484272896
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@iceberg.apache.org list. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] API: Remove stale TODO in VariantTestUtil.createArray [iceberg]
Posted by "github-actions[bot] (via GitHub) via issues" <is...@iceberg.apache.org>.
github-actions[bot] closed pull request #18253: API: Remove stale TODO in VariantTestUtil.createArray
URL: https://github.com/apache/iceberg/pull/18253
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] API: Remove stale TODO in VariantTestUtil.createArray [iceberg]
Posted by "github-actions[bot] (via GitHub) via issues" <is...@iceberg.apache.org>.
github-actions[bot] commented on PR #18253:
URL: https://github.com/apache/iceberg/pull/18253#issuecomment-6673055363
This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org