[GitHub] [skywalking-python] kezhenxu94 commented on a change in pull request #93: [Fix][Plugin] sw_flask general exceptions handled

[GitBox <gi...@apache.org>]

kezhenxu94 commented on a change in pull request #93:
URL: https://github.com/apache/skywalking-python/pull/93#discussion_r536441629



##########
File path: skywalking/trace/context.py
##########
@@ -150,22 +151,24 @@ def ignore_check(self, op: str, kind: Kind):
         return None
 
     def start(self, span: Span):
+        self.nspans += 1
         spans = _spans()
         if span not in spans:
             spans.append(span)
 
     def stop(self, span: Span) -> bool:
+        self.nspans -= 1

Review comment:
       move to line 165?

##########
File path: skywalking/trace/context.py
##########
@@ -74,6 +74,7 @@ def __init__(self):
         self.segment = Segment()  # type: Segment
         self._sid = Counter()
         self._correlation = {}  # type: dict
+        self.nspans = 0

Review comment:
       make it protected ?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org