[GitHub] [cloudstack] andrijapanicsb commented on a change in pull request #3917: Add logging around arping in CsAddress.py

[GitBox <gi...@apache.org>]

andrijapanicsb commented on a change in pull request #3917: Add logging around arping in CsAddress.py
URL: https://github.com/apache/cloudstack/pull/3917#discussion_r384104772
 
 

 ##########
 File path: systemvm/debian/opt/cloud/bin/cs/CsAddress.py
 ##########
 @@ -627,11 +627,14 @@ def hasIP(self, ip):
         return ip in self.address.values()
 
     def arpPing(self):
-        cmd = "arping -c 1 -I %s -A -U -s %s %s" % (
-            self.dev, self.address['public_ip'], self.address['gateway'])
+        #bit of logging added inside the command itself, to make sure whether it's executed or not (due to possible race/timeout conditions
+        cmd = "arping -c 1 -I %s -A -U -s %s %s >> /tmp/arpping.log" % (self.dev, self.address['public_ip'], self.address['gateway'])
         if not self.cl.is_redundant() and (not self.address['gateway'] or self.address['gateway'] == "None"):
-            cmd = "arping -c 1 -I %s -A -U %s" % (self.dev, self.address['public_ip'])
+                cmd = "arping -c 1 -I %s -A -U %s >> /tmp/arpping1.log" % (self.dev, self.address['public_ip'])
 
 Review comment:
   @svenvogel this is just a Draft PR, won't get merged most probably - and I don't get your question?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services