You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@parquet.apache.org by GitBox <gi...@apache.org> on 2021/01/13 09:38:38 UTC

[GitHub] [parquet-mr] chenjunjiedada commented on a change in pull request #852: PARQUET-1851: fix parquet metadata converter NPE

chenjunjiedada commented on a change in pull request #852:
URL: https://github.com/apache/parquet-mr/pull/852#discussion_r556384676



##########
File path: parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetFileWriter.java
##########
@@ -860,6 +860,10 @@ public void endColumn() throws IOException {
    * @throws IOException if there is an error while writing
    */
   public void endBlock() throws IOException {
+    if (currentRecordCount == 0) {
+      throw new IOException("End block with zero record");

Review comment:
       SGTM.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org