You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by yi...@apache.org on 2025/10/01 04:34:06 UTC
(doris) branch branch-4.0 updated: branch-4.0: [Fix](warmup) Fix wrongly skip download task for warmup job when rowsets have multi segments #56663 (#56681)
This is an automated email from the ASF dual-hosted git repository.
yiguolei pushed a commit to branch branch-4.0
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/branch-4.0 by this push:
new cc1914a374d branch-4.0: [Fix](warmup) Fix wrongly skip download task for warmup job when rowsets have multi segments #56663 (#56681)
cc1914a374d is described below
commit cc1914a374d0eeeaa905d6f510ff996a6decbd51
Author: github-actions[bot] <41...@users.noreply.github.com>
AuthorDate: Wed Oct 1 12:33:59 2025 +0800
branch-4.0: [Fix](warmup) Fix wrongly skip download task for warmup job when rowsets have multi segments #56663 (#56681)
Cherry-picked from #56663
Co-authored-by: bobhan1 <ba...@selectdb.com>
---
be/src/cloud/cloud_warm_up_manager.cpp | 37 +++++++++++++++++-----------------
1 file changed, 18 insertions(+), 19 deletions(-)
diff --git a/be/src/cloud/cloud_warm_up_manager.cpp b/be/src/cloud/cloud_warm_up_manager.cpp
index cbd45613444..fe61facd222 100644
--- a/be/src/cloud/cloud_warm_up_manager.cpp
+++ b/be/src/cloud/cloud_warm_up_manager.cpp
@@ -221,26 +221,25 @@ void CloudWarmUpManager::handle_jobs() {
auto tablet_meta = tablet->tablet_meta();
auto rs_metas = snapshot_rs_metas(tablet.get());
for (auto& [_, rs] : rs_metas) {
- for (int64_t seg_id = 0; seg_id < rs->num_segments(); seg_id++) {
- auto storage_resource = rs->remote_storage_resource();
- if (!storage_resource) {
- LOG(WARNING) << storage_resource.error();
- continue;
- }
-
- int64_t expiration_time =
- tablet_meta->ttl_seconds() == 0 || rs->newest_write_timestamp() <= 0
- ? 0
- : rs->newest_write_timestamp() + tablet_meta->ttl_seconds();
- if (expiration_time <= UnixSeconds()) {
- expiration_time = 0;
- }
- if (!tablet->add_rowset_warmup_state(*rs, WarmUpState::TRIGGERED_BY_JOB)) {
- LOG(INFO) << "found duplicate warmup task for rowset " << rs->rowset_id()
- << ", skip it";
- continue;
- }
+ auto storage_resource = rs->remote_storage_resource();
+ if (!storage_resource) {
+ LOG(WARNING) << storage_resource.error();
+ continue;
+ }
+ int64_t expiration_time =
+ tablet_meta->ttl_seconds() == 0 || rs->newest_write_timestamp() <= 0
+ ? 0
+ : rs->newest_write_timestamp() + tablet_meta->ttl_seconds();
+ if (expiration_time <= UnixSeconds()) {
+ expiration_time = 0;
+ }
+ if (!tablet->add_rowset_warmup_state(*rs, WarmUpState::TRIGGERED_BY_JOB)) {
+ LOG(INFO) << "found duplicate warmup task for rowset " << rs->rowset_id()
+ << ", skip it";
+ continue;
+ }
+ for (int64_t seg_id = 0; seg_id < rs->num_segments(); seg_id++) {
// 1st. download segment files
submit_download_tasks(
storage_resource.value()->remote_segment_path(*rs, seg_id),
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org