You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/10/14 01:36:57 UTC

[GitHub] [skywalking] wu-sheng commented on a change in pull request #5660: Fix Kafka sender blocks main thread

wu-sheng commented on a change in pull request #5660:
URL: https://github.com/apache/skywalking/pull/5660#discussion_r504349967



##########
File path: apm-sniffer/optional-reporter-plugins/kafka-reporter-plugin/src/main/java/org/apache/skywalking/apm/agent/core/kafka/KafkaTraceSegmentServiceClient.java
##########
@@ -72,13 +119,7 @@ public void afterFinished(final TraceSegment traceSegment) {
             LOGGER.debug("Trace[TraceId={}] is ignored.", traceSegment.getTraceSegmentId());

Review comment:
       @nileblack If you want to enhance more, we are welcome you to submit pull request.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org