You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/11/10 12:42:41 UTC
[GitHub] [apisix-dashboard] tokers opened a new pull request #773: chore: introduce corba as the cli scafford
tokers opened a new pull request #773:
URL: https://github.com/apache/apisix-dashboard/pull/773
Please answer these questions before submitting a pull request
- Why submit this pull request?
- [ ] Bugfix
- [ ] New feature provided
- [x] Improve performance
- Related issues
https://github.com/apache/apisix-dashboard/issues/739
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] starsz commented on pull request #773: chore: introduce corba as the cli scafford
Posted by GitBox <gi...@apache.org>.
starsz commented on pull request #773:
URL: https://github.com/apache/apisix-dashboard/pull/773#issuecomment-751179386
@tokers , What happen to the `.actions/openwhisk-utilities`?
Please see the file changes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] tokers commented on pull request #773: chore: introduce corba as the cli scafford
Posted by GitBox <gi...@apache.org>.
tokers commented on pull request #773:
URL: https://github.com/apache/apisix-dashboard/pull/773#issuecomment-750767227
License about new dependencies:
* github.com/cameront/go-jsonpatch MIT
* github.com/coreos/bbolt MIT
* github.com/dustin/go-humanize MIT
* github.com/golang/groupcache Apache 2.0
* github.com/grpc-ecosystem/go-grpc-middleware Apache 2.0
* github.com/grpc-ecosystem/grpc-gateway BSD 3.0
* github.com/jonboulle/clockwork Apache 2.0
* github.com/prometheus/client_golang Apache 2.0
* github.com/spf13/cobra Apache 2.0
* github.com/tmc/grpc-websocket-proxy MIT
* golang.org/x/time BSD 3.0
* sigs.k8s.io/yaml MIT
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #773: chore: introduce corba as the cli scafford
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #773:
URL: https://github.com/apache/apisix-dashboard/pull/773#issuecomment-747383388
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/773?src=pr&el=h1) Report
> Merging [#773](https://codecov.io/gh/apache/apisix-dashboard/pull/773?src=pr&el=desc) (b4bf55b) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/d1107ec866d15d8a2dec0932ae324c79afdcf9ff?el=desc) (d1107ec) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/773?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #773 +/- ##
=======================================
Coverage 40.13% 40.13%
=======================================
Files 26 26
Lines 1572 1572
=======================================
Hits 631 631
Misses 850 850
Partials 91 91
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/773?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/773?src=pr&el=footer). Last update [d1107ec...b4bf55b](https://codecov.io/gh/apache/apisix-dashboard/pull/773?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io commented on pull request #773: chore: introduce corba as the cli scafford
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #773:
URL: https://github.com/apache/apisix-dashboard/pull/773#issuecomment-747383388
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/773?src=pr&el=h1) Report
> Merging [#773](https://codecov.io/gh/apache/apisix-dashboard/pull/773?src=pr&el=desc) (8a529a1) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/d1107ec866d15d8a2dec0932ae324c79afdcf9ff?el=desc) (d1107ec) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/773?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #773 +/- ##
=======================================
Coverage 40.13% 40.13%
=======================================
Files 26 26
Lines 1572 1572
=======================================
Hits 631 631
Misses 850 850
Partials 91 91
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/773?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/773?src=pr&el=footer). Last update [d1107ec...8a529a1](https://codecov.io/gh/apache/apisix-dashboard/pull/773?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on pull request #773: chore: introduce corba as the cli scafford
Posted by GitBox <gi...@apache.org>.
nic-chen commented on pull request #773:
URL: https://github.com/apache/apisix-dashboard/pull/773#issuecomment-745980879
@tokers
CI failed and we need test case for the change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] membphis commented on a change in pull request #773: chore: introduce corba as the cli scafford
Posted by GitBox <gi...@apache.org>.
membphis commented on a change in pull request #773:
URL: https://github.com/apache/apisix-dashboard/pull/773#discussion_r547309782
##########
File path: api/go.sum
##########
@@ -1,30 +1,86 @@
+cloud.google.com/go v0.34.0/go.mod h1:aQUYkXzVsufM+DwF1aE+0xfcU+56JwCaLick0ClmMTw=
Review comment:
Need to confirm the license of these new dependencies
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #773: chore: introduce corba as the cli scafford
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #773:
URL: https://github.com/apache/apisix-dashboard/pull/773#issuecomment-747383388
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/773?src=pr&el=h1) Report
> Merging [#773](https://codecov.io/gh/apache/apisix-dashboard/pull/773?src=pr&el=desc) (8929363) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/b3463fda2c949833d5dba2c12c8fe3ab6a25399a?el=desc) (b3463fd) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/773?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #773 +/- ##
=======================================
Coverage 41.72% 41.72%
=======================================
Files 29 29
Lines 1819 1819
=======================================
Hits 759 759
Misses 951 951
Partials 109 109
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/773?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/773?src=pr&el=footer). Last update [b3463fd...8929363](https://codecov.io/gh/apache/apisix-dashboard/pull/773?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] membphis commented on pull request #773: chore: introduce corba as the cli scafford
Posted by GitBox <gi...@apache.org>.
membphis commented on pull request #773:
URL: https://github.com/apache/apisix-dashboard/pull/773#issuecomment-749567465
@tokers need to resolve the conflicts
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] membphis commented on a change in pull request #773: chore: introduce corba as the cli scafford
Posted by GitBox <gi...@apache.org>.
membphis commented on a change in pull request #773:
URL: https://github.com/apache/apisix-dashboard/pull/773#discussion_r548807322
##########
File path: api/go.sum
##########
@@ -1,30 +1,86 @@
+cloud.google.com/go v0.34.0/go.mod h1:aQUYkXzVsufM+DwF1aE+0xfcU+56JwCaLick0ClmMTw=
Review comment:
nice
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #773: chore: introduce corba as the cli scafford
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #773:
URL: https://github.com/apache/apisix-dashboard/pull/773#issuecomment-747383388
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/773?src=pr&el=h1) Report
> Merging [#773](https://codecov.io/gh/apache/apisix-dashboard/pull/773?src=pr&el=desc) (a8352ff) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/d2b577298d4b86ea120fda718e21478cd94e82eb?el=desc) (d2b5772) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/773?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #773 +/- ##
=======================================
Coverage 41.40% 41.40%
=======================================
Files 28 28
Lines 1785 1785
=======================================
Hits 739 739
Misses 940 940
Partials 106 106
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/773?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/773?src=pr&el=footer). Last update [d2b5772...a8352ff](https://codecov.io/gh/apache/apisix-dashboard/pull/773?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] tokers commented on a change in pull request #773: chore: introduce corba as the cli scafford
Posted by GitBox <gi...@apache.org>.
tokers commented on a change in pull request #773:
URL: https://github.com/apache/apisix-dashboard/pull/773#discussion_r548784027
##########
File path: api/go.sum
##########
@@ -1,30 +1,86 @@
+cloud.google.com/go v0.34.0/go.mod h1:aQUYkXzVsufM+DwF1aE+0xfcU+56JwCaLick0ClmMTw=
Review comment:
License of all packages are checked, everything is OK.
- github.com/cameront/go-jsonpatch MIT
- github.com/coreos/bbolt MIT
- github.com/dustin/go-humanize MIT
- github.com/golang/groupcache Apache 2.0
- github.com/grpc-ecosystem/go-grpc-middleware Apache 2.0
- github.com/grpc-ecosystem/grpc-gateway BSD 3.0
- github.com/jonboulle/clockwork Apache 2.0
- github.com/prometheus/client_golang Apache 2.0
- github.com/spf13/cobra Apache 2.0
- github.com/tmc/grpc-websocket-proxy MIT
- golang.org/x/time BSD 3.0
- sigs.k8s.io/yaml MIT
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #773: chore: introduce corba as the cli scafford
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #773:
URL: https://github.com/apache/apisix-dashboard/pull/773#issuecomment-747383388
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/773?src=pr&el=h1) Report
> Merging [#773](https://codecov.io/gh/apache/apisix-dashboard/pull/773?src=pr&el=desc) (1db845e) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/0e6e2805362a8dc9b83f56f53be17f12a8ddbacf?el=desc) (0e6e280) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/773?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #773 +/- ##
=======================================
Coverage 41.94% 41.94%
=======================================
Files 29 29
Lines 1824 1824
=======================================
Hits 765 765
Misses 951 951
Partials 108 108
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/773?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/773?src=pr&el=footer). Last update [0e6e280...1db845e](https://codecov.io/gh/apache/apisix-dashboard/pull/773?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] tokers commented on pull request #773: chore: introduce corba as the cli scafford
Posted by GitBox <gi...@apache.org>.
tokers commented on pull request #773:
URL: https://github.com/apache/apisix-dashboard/pull/773#issuecomment-746163079
> @tokers
> CI failed and we need test case for the change.
OK, i will resolve it as soon as possible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] tokers commented on pull request #773: chore: introduce corba as the cli scafford
Posted by GitBox <gi...@apache.org>.
tokers commented on pull request #773:
URL: https://github.com/apache/apisix-dashboard/pull/773#issuecomment-743017970
@nic-chen @membphis Now this PR can be reviewed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] tokers merged pull request #773: chore: introduce corba as the cli scafford
Posted by GitBox <gi...@apache.org>.
tokers merged pull request #773:
URL: https://github.com/apache/apisix-dashboard/pull/773
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #773: chore: introduce corba as the cli scafford
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #773:
URL: https://github.com/apache/apisix-dashboard/pull/773#issuecomment-747383388
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/773?src=pr&el=h1) Report
> Merging [#773](https://codecov.io/gh/apache/apisix-dashboard/pull/773?src=pr&el=desc) (45b0fd3) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/46bf1ef9cfe4f4c659752176424151bb4fc4952f?el=desc) (46bf1ef) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/773?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #773 +/- ##
=======================================
Coverage 41.06% 41.06%
=======================================
Files 28 28
Lines 1773 1773
=======================================
Hits 728 728
Misses 939 939
Partials 106 106
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/773?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/773?src=pr&el=footer). Last update [46bf1ef...45b0fd3](https://codecov.io/gh/apache/apisix-dashboard/pull/773?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] tokers commented on pull request #773: chore: introduce corba as the cli scafford
Posted by GitBox <gi...@apache.org>.
tokers commented on pull request #773:
URL: https://github.com/apache/apisix-dashboard/pull/773#issuecomment-744185657
> @tokers conflict again..
Resolved.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on pull request #773: chore: introduce corba as the cli scafford
Posted by GitBox <gi...@apache.org>.
nic-chen commented on pull request #773:
URL: https://github.com/apache/apisix-dashboard/pull/773#issuecomment-744142582
@tokers conflict again..
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #773: chore: introduce corba as the cli scafford
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #773:
URL: https://github.com/apache/apisix-dashboard/pull/773#issuecomment-747383388
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/773?src=pr&el=h1) Report
> Merging [#773](https://codecov.io/gh/apache/apisix-dashboard/pull/773?src=pr&el=desc) (0d020a4) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/0895900ce5586fc2cb91ca02adf9ab682eb657ec?el=desc) (0895900) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/773?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #773 +/- ##
=======================================
Coverage 41.40% 41.40%
=======================================
Files 28 28
Lines 1785 1785
=======================================
Hits 739 739
Misses 940 940
Partials 106 106
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/773?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/773?src=pr&el=footer). Last update [0895900...0d020a4](https://codecov.io/gh/apache/apisix-dashboard/pull/773?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] tokers commented on pull request #773: chore: introduce corba as the cli scafford
Posted by GitBox <gi...@apache.org>.
tokers commented on pull request #773:
URL: https://github.com/apache/apisix-dashboard/pull/773#issuecomment-751184427
> @tokers , What happen to the `.actions/openwhisk-utilities`?
> Please see the file changes.
We don't reference it as a submodule, just download it and use it in CI.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #773: chore: introduce corba as the cli scafford
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #773:
URL: https://github.com/apache/apisix-dashboard/pull/773#issuecomment-747383388
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/773?src=pr&el=h1) Report
> Merging [#773](https://codecov.io/gh/apache/apisix-dashboard/pull/773?src=pr&el=desc) (45b0fd3) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/46bf1ef9cfe4f4c659752176424151bb4fc4952f?el=desc) (46bf1ef) will **increase** coverage by `1.71%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/773?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #773 +/- ##
==========================================
+ Coverage 41.06% 42.77% +1.71%
==========================================
Files 28 29 +1
Lines 1773 1985 +212
==========================================
+ Hits 728 849 +121
- Misses 939 1026 +87
- Partials 106 110 +4
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/773?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [api/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/773/diff?src=pr&el=tree#diff-YXBpL2ZpbHRlci9zY2hlbWEuZ28=) | `0.00% <0.00%> (ø)` | |
| [api/internal/utils/consts/api\_error.go](https://codecov.io/gh/apache/apisix-dashboard/pull/773/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2NvbnN0cy9hcGlfZXJyb3IuZ28=) | `95.65% <0.00%> (ø)` | |
| [api/internal/handler/consumer/consumer.go](https://codecov.io/gh/apache/apisix-dashboard/pull/773/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvY29uc3VtZXIvY29uc3VtZXIuZ28=) | `70.66% <0.00%> (+2.03%)` | :arrow_up: |
| [api/internal/handler/ssl/ssl.go](https://codecov.io/gh/apache/apisix-dashboard/pull/773/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc3NsL3NzbC5nbw==) | `35.22% <0.00%> (+5.74%)` | :arrow_up: |
| [api/internal/utils/utils.go](https://codecov.io/gh/apache/apisix-dashboard/pull/773/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3V0aWxzLmdv) | `65.21% <0.00%> (+8.32%)` | :arrow_up: |
| [api/internal/handler/plugin/plugin.go](https://codecov.io/gh/apache/apisix-dashboard/pull/773/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcGx1Z2luL3BsdWdpbi5nbw==) | `75.67% <0.00%> (+20.12%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/773?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/773?src=pr&el=footer). Last update [46bf1ef...45b0fd3](https://codecov.io/gh/apache/apisix-dashboard/pull/773?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] membphis commented on pull request #773: WIP: chore: introduce corba as the cli scafford
Posted by GitBox <gi...@apache.org>.
membphis commented on pull request #773:
URL: https://github.com/apache/apisix-dashboard/pull/773#issuecomment-742923358
@tokers any news?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #773: chore: introduce corba as the cli scafford
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #773:
URL: https://github.com/apache/apisix-dashboard/pull/773#issuecomment-750768003
ping @membphis
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #773: chore: introduce corba as the cli scafford
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #773:
URL: https://github.com/apache/apisix-dashboard/pull/773#issuecomment-747383388
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/773?src=pr&el=h1) Report
> Merging [#773](https://codecov.io/gh/apache/apisix-dashboard/pull/773?src=pr&el=desc) (dd52205) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/266605229184a501a7bbf40e19e67df68d3367f3?el=desc) (2666052) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/773?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #773 +/- ##
=======================================
Coverage 41.94% 41.94%
=======================================
Files 29 29
Lines 1824 1824
=======================================
Hits 765 765
Misses 951 951
Partials 108 108
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/773?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/773?src=pr&el=footer). Last update [2666052...dd52205](https://codecov.io/gh/apache/apisix-dashboard/pull/773?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] tokers commented on pull request #773: WIP: chore: introduce corba as the cli scafford
Posted by GitBox <gi...@apache.org>.
tokers commented on pull request #773:
URL: https://github.com/apache/apisix-dashboard/pull/773#issuecomment-742924566
@membphis Soory i forgot this, i will update it as soon as possible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org