You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Mike Percy (Code Review)" <ge...@cloudera.org> on 2019/01/11 17:05:03 UTC
[kudu-CR] docs: Add Gerrit HTTP endpoint instructions
Mike Percy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12218
Change subject: docs: Add Gerrit HTTP endpoint instructions
......................................................................
docs: Add Gerrit HTTP endpoint instructions
Some users cannot use SSH to connect to Gerrit. We should provide
explicit instructions for these users on how to submit a patch via
Gerrit so they don't have to figure it out themselves from the Gerrit
docs.
Change-Id: I70eb2abf6d4c11500d50be27e398bdf0cb3f85c2
---
M docs/contributing.adoc
1 file changed, 36 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/18/12218/1
--
To view, visit http://gerrit.cloudera.org:8080/12218
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I70eb2abf6d4c11500d50be27e398bdf0cb3f85c2
Gerrit-Change-Number: 12218
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy <mp...@apache.org>
[kudu-CR] docs: Add Gerrit HTTP endpoint instructions
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12218 )
Change subject: docs: Add Gerrit HTTP endpoint instructions
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12218
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I70eb2abf6d4c11500d50be27e398bdf0cb3f85c2
Gerrit-Change-Number: 12218
Gerrit-PatchSet: 2
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Fri, 11 Jan 2019 22:55:30 +0000
Gerrit-HasComments: No
[kudu-CR] docs: Add Gerrit HTTP endpoint instructions
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12218
to look at the new patch set (#2).
Change subject: docs: Add Gerrit HTTP endpoint instructions
......................................................................
docs: Add Gerrit HTTP endpoint instructions
Some users cannot use SSH to connect to Gerrit. We should provide
explicit instructions for these users on how to submit a patch via
Gerrit so they don't have to figure it out themselves from the Gerrit
docs.
Change-Id: I70eb2abf6d4c11500d50be27e398bdf0cb3f85c2
---
M docs/contributing.adoc
1 file changed, 37 insertions(+), 8 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/18/12218/2
--
To view, visit http://gerrit.cloudera.org:8080/12218
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I70eb2abf6d4c11500d50be27e398bdf0cb3f85c2
Gerrit-Change-Number: 12218
Gerrit-PatchSet: 2
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] docs: Add Gerrit HTTP endpoint instructions
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12218 )
Change subject: docs: Add Gerrit HTTP endpoint instructions
......................................................................
Patch Set 1:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/12218/1/docs/contributing.adoc
File docs/contributing.adoc:
http://gerrit.cloudera.org:8080/#/c/12218/1/docs/contributing.adoc@43
PS1, Line 43: . Go to link:http://gerrit.cloudera.org:8080/#/settings/[Settings]. Update your name
> Should we offer a recommendation for which protocol to use?
Done
http://gerrit.cloudera.org:8080/#/c/12218/1/docs/contributing.adoc@52
PS1, Line 52: . If you have not done so, clone the main Kudu repository. By default, the main remote
> This got renumbered in the render (it's now a new numbered list instead of
Thanks for the catch, fixed
http://gerrit.cloudera.org:8080/#/c/12218/1/docs/contributing.adoc@64
PS1, Line 64: If you have uploaded an SSH public key (see above) and would like to use SSH to
: connect to Gerrit,
> Nit: more terse as "If using SSH to connect to Gerrit, ..."
Done
http://gerrit.cloudera.org:8080/#/c/12218/1/docs/contributing.adoc@73
PS1, Line 73: If you have generated an HTTP password (see above) and would like to use HTTP
> Nit: more terse as "If using HTTP or HTTPS to connect to Gerrit, ..."
Done
http://gerrit.cloudera.org:8080/#/c/12218/1/docs/contributing.adoc@84
PS1, Line 84: If you are using the HTTP / HTTPS endpoint for Gerrit and prefer not to type a
> Nit: "If you are using Gerrit's HTTP or HTTPS endpoints and prefer..."
Done
--
To view, visit http://gerrit.cloudera.org:8080/12218
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I70eb2abf6d4c11500d50be27e398bdf0cb3f85c2
Gerrit-Change-Number: 12218
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Fri, 11 Jan 2019 21:45:05 +0000
Gerrit-HasComments: Yes
[kudu-CR] docs: Add Gerrit HTTP endpoint instructions
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12218 )
Change subject: docs: Add Gerrit HTTP endpoint instructions
......................................................................
Patch Set 1:
Render: https://github.com/mpercy/kudu/blob/doc-gerrit-1/docs/contributing.adoc#initial-setup-for-gerrit
--
To view, visit http://gerrit.cloudera.org:8080/12218
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I70eb2abf6d4c11500d50be27e398bdf0cb3f85c2
Gerrit-Change-Number: 12218
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Fri, 11 Jan 2019 17:06:14 +0000
Gerrit-HasComments: No
[kudu-CR] docs: Add Gerrit HTTP endpoint instructions
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12218 )
Change subject: docs: Add Gerrit HTTP endpoint instructions
......................................................................
Patch Set 1:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/12218/1/docs/contributing.adoc
File docs/contributing.adoc:
http://gerrit.cloudera.org:8080/#/c/12218/1/docs/contributing.adoc@43
PS1, Line 43: . Go to link:http://gerrit.cloudera.org:8080/#/settings/[Settings]. Update your name
Should we offer a recommendation for which protocol to use?
http://gerrit.cloudera.org:8080/#/c/12218/1/docs/contributing.adoc@52
PS1, Line 52: . If you have not done so, clone the main Kudu repository. By default, the main remote
This got renumbered in the render (it's now a new numbered list instead of bullet #3).
http://gerrit.cloudera.org:8080/#/c/12218/1/docs/contributing.adoc@64
PS1, Line 64: If you have uploaded an SSH public key (see above) and would like to use SSH to
: connect to Gerrit,
Nit: more terse as "If using SSH to connect to Gerrit, ..."
http://gerrit.cloudera.org:8080/#/c/12218/1/docs/contributing.adoc@73
PS1, Line 73: If you have generated an HTTP password (see above) and would like to use HTTP
Nit: more terse as "If using HTTP or HTTPS to connect to Gerrit, ..."
http://gerrit.cloudera.org:8080/#/c/12218/1/docs/contributing.adoc@84
PS1, Line 84: If you are using the HTTP / HTTPS endpoint for Gerrit and prefer not to type a
Nit: "If you are using Gerrit's HTTP or HTTPS endpoints and prefer..."
--
To view, visit http://gerrit.cloudera.org:8080/12218
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I70eb2abf6d4c11500d50be27e398bdf0cb3f85c2
Gerrit-Change-Number: 12218
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Fri, 11 Jan 2019 20:19:53 +0000
Gerrit-HasComments: Yes
[kudu-CR] docs: Add Gerrit HTTP endpoint instructions
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12218 )
Change subject: docs: Add Gerrit HTTP endpoint instructions
......................................................................
docs: Add Gerrit HTTP endpoint instructions
Some users cannot use SSH to connect to Gerrit. We should provide
explicit instructions for these users on how to submit a patch via
Gerrit so they don't have to figure it out themselves from the Gerrit
docs.
Change-Id: I70eb2abf6d4c11500d50be27e398bdf0cb3f85c2
Reviewed-on: http://gerrit.cloudera.org:8080/12218
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
---
M docs/contributing.adoc
1 file changed, 37 insertions(+), 8 deletions(-)
Approvals:
Kudu Jenkins: Verified
Adar Dembo: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/12218
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I70eb2abf6d4c11500d50be27e398bdf0cb3f85c2
Gerrit-Change-Number: 12218
Gerrit-PatchSet: 3
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] docs: Add Gerrit HTTP endpoint instructions
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12218 )
Change subject: docs: Add Gerrit HTTP endpoint instructions
......................................................................
Patch Set 2:
Updated the rendering noted in Patch Set 1
--
To view, visit http://gerrit.cloudera.org:8080/12218
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I70eb2abf6d4c11500d50be27e398bdf0cb3f85c2
Gerrit-Change-Number: 12218
Gerrit-PatchSet: 2
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Fri, 11 Jan 2019 21:46:18 +0000
Gerrit-HasComments: No