You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/09/22 18:29:00 UTC
[jira] [Commented] (BEAM-419) Non-transient non-serializable
instance field in CombineFnUtil$NonSerializableBoundedKeyedCombineFn
[ https://issues.apache.org/jira/browse/BEAM-419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16176885#comment-16176885 ]
ASF GitHub Bot commented on BEAM-419:
-------------------------------------
GitHub user youngoli opened a pull request:
https://github.com/apache/beam/pull/3886
[BEAM-419] Fixing SE_BAD_FIELD FindBug in CombineFnUtil
Follow this checklist to help us incorporate your contribution quickly and easily:
- [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/projects/BEAM/issues/) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
- [x] Each commit in the pull request should have a meaningful subject line and body.
- [x] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
---
FindBugs detected that the `context` member in `NonSerializableBoundedKeyedCombineFn` (now `NonSerializableBoundedCombineFn`) was not serializable although the class was. Seeing as the class has "`NonSerializable`" right in the name, to fix the FindBug I marked the member as transient to make it explicitly non-serializable.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/youngoli/beam bugfix-beam419
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/3886.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3886
----
commit 0a9f01cffd686985bd0e7a889ad3c36524e84ed5
Author: Daniel Oliveira <da...@gmail.com>
Date: 2017-09-22T17:40:29Z
[BEAM-419] Making non-serializable member transient to fix FindBug
commit d0491d2c2e229eb34e202833ab6bed4d344cd18b
Author: Daniel Oliveira <da...@gmail.com>
Date: 2017-09-22T18:23:30Z
[BEAM-419] Removing findbug entry for fixed bug.
----
> Non-transient non-serializable instance field in CombineFnUtil$NonSerializableBoundedKeyedCombineFn
> ---------------------------------------------------------------------------------------------------
>
> Key: BEAM-419
> URL: https://issues.apache.org/jira/browse/BEAM-419
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-core
> Reporter: Scott Wegner
> Assignee: Daniel Oliveira
> Priority: Minor
> Labels: findbugs, newbie, starter
>
> [FindBugs SE_BAD_FIELD|https://github.com/apache/incubator-beam/blob/58a029a06aea1030279e5da8f9fa3114f456c1db/sdks/java/build-tools/src/main/resources/beam/findbugs-filter.xml#L363]: Non-transient non-serializable instance field in serializable class
> Applies to: [CombineFnUtil$NonSerializableBoundedKeyedCombineFn.context|https://github.com/apache/incubator-beam/blob/58a029a06aea1030279e5da8f9fa3114f456c1db/sdks/java/core/src/main/java/org/apache/beam/sdk/util/CombineFnUtil.java#L170].
> This is a good starter bug. When fixing, please remove the corresponding entries from [findbugs-filter.xml|https://github.com/apache/incubator-beam/blob/master/sdks/java/build-tools/src/main/resources/beam/findbugs-filter.xml] and verify the build passes.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)