You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@carbondata.apache.org by GitBox <gi...@apache.org> on 2021/08/11 15:22:18 UTC

[GitHub] [carbondata] kunal642 commented on pull request #4189: [CARBONDATA-4263]support query with latestSegment

kunal642 commented on pull request #4189:
URL: https://github.com/apache/carbondata/pull/4189#issuecomment-896919611


   @MarvinLitt 
   1. the new csv is not needed as we already have several csv in our resources, use any one of the existing one(this is not needed if point 2 is done)
   2. better to use insert instead of load and no need for filter condition, just use select * because this is not related to any filter.
   3. I can see only 2-3 conditions in your test cases, better to add them in a existing test suite, please avoid creating new test files unless absolutely necessary


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org