You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "Nishieee (via GitHub)" <gi...@apache.org> on 2026/05/14 19:22:02 UTC
[PR] Preserve Databricks deferrable trigger caller across triggerer restarts [airflow]
Nishieee opened a new pull request, #66965:
URL: https://github.com/apache/airflow/pull/66965
`DatabricksExecutionTrigger` and `DatabricksSQLStatementExecutionTrigger` passed `caller` into `DatabricksHook` but omitted it from `serialize()`, so the triggerer lost the operator’s value after restart/handoff. Persist `caller` on the instance, include it in `serialize()`, and add tests for default serialization and round-trip.
related: #66961
---
##### Was generative AI tooling used to co-author this PR?
- [X] Yes — Cursor
Generated-by: Cursor following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Preserve Databricks deferrable trigger caller across triggerer restarts [airflow]
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #66965:
URL: https://github.com/apache/airflow/pull/66965#issuecomment-4454007592
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our [Contributors' Guide](https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:
- Pay attention to the quality of your code (ruff, mypy and type annotations). Our [prek-hooks]( https://github.com/apache/airflow/blob/main/contributing-docs/08_static_code_checks.rst#prerequisites-for-prek-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/airflow-core/docs/howto/custom-operator.rst) Consider adding an example Dag that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/dev/breeze/doc/README.rst) for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#coding-style-and-best-practices).
- Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Preserve Databricks deferrable trigger caller across triggerer restarts [airflow]
Posted by "Nishieee (via GitHub)" <gi...@apache.org>.
Nishieee commented on code in PR #66965:
URL: https://github.com/apache/airflow/pull/66965#discussion_r3249020553
##########
providers/databricks/src/airflow/providers/databricks/triggers/databricks.py:
##########
Review Comment:
Thanks for the review!! addressed all of the above: added repair_run and caller to the DatabricksExecutionTrigger docstring, caller to the DatabricksSQLStatementExecutionTrigger docstring, and a shared CALLER module constant used in both serialize round-trip tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Preserve Databricks deferrable trigger caller across triggerer restarts [airflow]
Posted by "SameerMesiah97 (via GitHub)" <gi...@apache.org>.
SameerMesiah97 commented on code in PR #66965:
URL: https://github.com/apache/airflow/pull/66965#discussion_r3245071384
##########
providers/databricks/src/airflow/providers/databricks/triggers/databricks.py:
##########
Review Comment:
Should we not add docstring entries for `repair_run` and `caller`?
##########
providers/databricks/tests/unit/databricks/triggers/test_databricks.py:
##########
Review Comment:
I would add a constant called `CALLER` here and then use that in your tests.. I think it's okay to use the same `caller` argument for both as the string itself is not behaviorally important
##########
providers/databricks/src/airflow/providers/databricks/triggers/databricks.py:
##########
Review Comment:
Same here. I think we should add a docstring entry for `caller`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Preserve Databricks deferrable trigger caller across triggerer restarts [airflow]
Posted by "SameerMesiah97 (via GitHub)" <gi...@apache.org>.
SameerMesiah97 commented on PR #66965:
URL: https://github.com/apache/airflow/pull/66965#issuecomment-4461617458
@Nishieee
CI needs to be triggered.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Preserve Databricks deferrable trigger caller across triggerer restarts [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #66965:
URL: https://github.com/apache/airflow/pull/66965
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org