[GitHub] [fineract] galovics commented on a diff in pull request #2300: FINERACT-1528: Replace copy and pasted Swagger UI with Springdoc

[GitBox <gi...@apache.org>]

galovics commented on code in PR #2300:
URL: https://github.com/apache/fineract/pull/2300#discussion_r860963122


##########
fineract-client/build.gradle:
##########
@@ -72,26 +72,23 @@ task buildTypescriptAngularSdk(type: org.openapitools.generator.gradle.plugin.ta
     skipValidateSpec = true
     inputSpec = "file:///$swaggerFile"
     outputDir = "$buildDir/generated/typescript".toString()
-    apiPackage = 'org.apache.fineract.client.services'
-    invokerPackage = 'org.apache.fineract.client'
-    modelPackage = 'org.apache.fineract.client.models'
+    apiPackage = 'apache-fineract-client/services'
+    invokerPackage = 'apache-fineract-client/invoker'
+    modelPackage = 'apache-fineract-client/models'
     configOptions = [
-        apiModulePrefix: 'fineract',
-        configurationPrefix: 'fineract',
+        apiModulePrefix: 'apacheFineractClient',
+        configurationPrefix: 'apacheFineractClient',
         ngVersion: '12.0.0',
-        npmName: 'apache-fineract-client'
+        npmName: '@apache/fineract-client',
+        npmRepository: "${npmRepository}"
     ]
     dependsOn = [
         ':fineract-provider:resolve'
     ]
 }
 
-licenseFormatMain.dependsOn buildJavaSdk

Review Comment:
   Wait a sec. Are you sure this is gonna be replaced by the change below?
   
   When I was fixing the incremental build for Gradle, this combination worker flawlessly. Have you tested whether it's broken?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org