[GitHub] [rocketmq-externals] vongosling commented on a change in pull request #744: [ISSUE #743] Implement RocketMQ message trace UI

[GitBox <gi...@apache.org>]

vongosling commented on a change in pull request #744:
URL: https://github.com/apache/rocketmq-externals/pull/744#discussion_r663741680



##########
File path: rocketmq-console/src/main/java/org/apache/rocketmq/console/model/trace/TraceNode.java
##########
@@ -0,0 +1,30 @@
+package org.apache.rocketmq.console.model.trace;/*

Review comment:
       Need to update...

##########
File path: rocketmq-console/pom.xml
##########
@@ -264,6 +269,22 @@
                 <artifactId>findbugs-maven-plugin</artifactId>
                 <version>3.0.4</version>
             </plugin>
+            <plugin>
+                <groupId>org.apache.maven.plugins</groupId>
+                <artifactId>maven-compiler-plugin</artifactId>
+                <version>3.6.2</version>
+                <configuration>
+                    <source>1.8</source>

Review comment:
       You could remove configuration parts while just leave annotationProcessorPaths here. refer to the properties in the pom of RocketMQ.

##########
File path: rocketmq-console/src/test/java/org/apache/rocketmq/console/service/impl/MessageTraceServiceImplTest.java
##########
@@ -0,0 +1,137 @@
+package org.apache.rocketmq.console.service.impl;
+
+import java.nio.charset.StandardCharsets;
+import java.util.Collection;
+import java.util.Collections;
+import java.util.List;
+import lombok.SneakyThrows;
+import org.apache.rocketmq.client.QueryResult;
+import org.apache.rocketmq.common.message.MessageExt;
+import org.apache.rocketmq.console.config.RMQConfigure;
+import org.apache.rocketmq.console.model.MessageTraceView;
+import org.apache.rocketmq.console.model.trace.MessageTraceGraph;
+import org.apache.rocketmq.console.util.JsonUtil;
+import org.apache.rocketmq.tools.admin.MQAdminExt;
+import org.assertj.core.util.Lists;
+import org.junit.jupiter.api.Assertions;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
+import org.junit.runner.RunWith;
+import org.mockito.InjectMocks;
+import org.mockito.Mock;
+import org.mockito.Mockito;
+import org.mockito.MockitoAnnotations;
+import org.mockito.junit.MockitoJUnitRunner;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more

Review comment:
       License ...

##########
File path: rocketmq-console/src/main/java/org/apache/rocketmq/console/model/trace/MessageTraceGraph.java
##########
@@ -0,0 +1,29 @@
+package org.apache.rocketmq.console.model.trace;/*

Review comment:
       License should be before package parts.
   
   

##########
File path: rocketmq-console/src/main/java/org/apache/rocketmq/console/service/impl/MessageTraceServiceImpl.java
##########
@@ -47,8 +79,99 @@
                 messageTraceViews.addAll(messageTraceView);
             }
             return messageTraceViews;
-        } catch (Exception err) {
+        }
+        catch (Exception err) {

Review comment:
       Checkstyle will pass here?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org