You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@jclouds.apache.org by Andrew Gaul <no...@github.com> on 2014/03/20 20:32:57 UTC

[jclouds] JCLOUDS-505: Remove unused ObjectMD5 (#321)

The only users of this seem to be
org.jclouds.atmos.blobstore.strategy.FindMD5InUserMetadata and
org.jclouds.azureblob.blobstore.strategy.FindMD5InBlobProperties which
are themselves unused.
You can merge this Pull Request by running:

  git pull https://github.com/maginatics/jclouds remove-object-md5

Or you can view, comment on it, or merge it online at:

  https://github.com/jclouds/jclouds/pull/321

-- Commit Summary --

  * JCLOUDS-505: Remove unused ObjectMD5

-- File Changes --

    M apis/atmos/src/main/java/org/jclouds/atmos/blobstore/config/AtmosBlobStoreContextModule.java (3)
    D apis/atmos/src/main/java/org/jclouds/atmos/blobstore/strategy/FindMD5InUserMetadata.java (130)
    D apis/atmos/src/test/java/org/jclouds/atmos/blobstore/config/AtmosBlobStoreModuleTest.java (62)
    D blobstore/src/main/java/org/jclouds/blobstore/functions/ObjectMD5.java (56)
    D blobstore/src/main/java/org/jclouds/blobstore/strategy/ContainsValueInListStrategy.java (34)
    D blobstore/src/main/java/org/jclouds/blobstore/strategy/internal/FindMD5InList.java (66)
    D blobstore/src/test/java/org/jclouds/blobstore/functions/ObjectMD5Test.java (62)
    M providers/azureblob/src/main/java/org/jclouds/azureblob/blobstore/config/AzureBlobStoreContextModule.java (3)
    D providers/azureblob/src/main/java/org/jclouds/azureblob/blobstore/strategy/FindMD5InBlobProperties.java (72)
    D providers/azureblob/src/test/java/org/jclouds/azureblob/blobstore/config/AzureBlobStoreModuleTest.java (45)

-- Patch Links --

https://github.com/jclouds/jclouds/pull/321.patch
https://github.com/jclouds/jclouds/pull/321.diff

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/321

Re: [jclouds] JCLOUDS-505: Remove unused ObjectMD5 (#321)

Posted by Andrew Phillips <no...@github.com>.

Closed #321.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/321#event-118577452

Re: [jclouds] JCLOUDS-505: Remove unused ObjectMD5 (#321)

Posted by Andrew Phillips <no...@github.com>.

Pending PR builders, definitely +1, good to go for me - thanks for the cleanup, @andrewgaul! Do we know if e.g. this is maybe used in labs?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/321#issuecomment-38211729

Re: [jclouds] JCLOUDS-505: Remove unused ObjectMD5 (#321)

Posted by Jeremy Daggett <no...@github.com>.

+1 @demobox I checked in the jclouds-labs project and found no other references. Looks good to merge. cc @andrewgaul 

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/321#issuecomment-42352951

Re: [jclouds] JCLOUDS-505: Remove unused ObjectMD5 (#321)

Posted by Andrew Phillips <no...@github.com>.

Thanks for checking, @jdaggett! Committed to [master](https://git-wip-us.apache.org/repos/asf?p=jclouds.git;a=commit;h=a45124c51a80e96f033059584dd4ef3763b56804)

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/321#issuecomment-42400806

Re: [jclouds] JCLOUDS-505: Remove unused ObjectMD5 (#321)

Posted by BuildHive <no...@github.com>.

[jclouds » jclouds #929](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/929/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/321#issuecomment-38216413

Re: [jclouds] JCLOUDS-505: Remove unused ObjectMD5 (#321)

Posted by CloudBees pull request builder plugin <no...@github.com>.

[jclouds-java-7-pull-requests #1144](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1144/) SUCCESS
This pull request looks good

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/321#issuecomment-38217877

Re: [jclouds] JCLOUDS-505: Remove unused ObjectMD5 (#321)

Posted by CloudBees pull request builder plugin <no...@github.com>.

[jclouds-pull-requests #674](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/674/) SUCCESS
This pull request looks good

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/321#issuecomment-38217431