[GitHub] [ozone] adoroszlai commented on pull request #4936: HDDS-8553. Improve scanner integration tests.

["adoroszlai (via GitHub)" <gi...@apache.org>]

adoroszlai commented on PR #4936:
URL: https://github.com/apache/ozone/pull/4936#issuecomment-1603999694

   Thanks @errose28 for the patch, @hemantk-12, @sumitagrawl for the review.
   
   > nit: since it is new code, it would be great if you use JUnit-5 and its parameterized tests.
   
   100% agree, we should make this a recommendation.  In this case I think we can file a follow-up task: the tests are useful in their current form and there is no harm in having them as JUnit4 for some time.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org