[GitHub] [calcite-avatica-go] F21 commented on issue #42: forward all query parameters from the dsn in the OpenConnectionRequest info object.

[GitBox <gi...@apache.org>]

F21 commented on issue #42: forward all query parameters from the dsn in the OpenConnectionRequest info object.
URL: https://github.com/apache/calcite-avatica-go/pull/42#issuecomment-508423339
 
 
   Similar to my comment on #41, I propose that instead of doing this, we add a `map[string]string` to the `Connector` struct that can be used to hold these values and add them to the request when opening the connection. In addition, I think we should remove the current `username` and `password` parameters from the DSN (https://calcite.apache.org/avatica/docs/go_client_reference.html#username) as they are passed directly to avatica and let users who need these to pass them in via the map.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services