[GitHub] [accumulo] cshannon commented on a diff in pull request #2799: Adding support for setting multiple properties at once atomically

[GitBox <gi...@apache.org>]

cshannon commented on code in PR #2799:
URL: https://github.com/apache/accumulo/pull/2799#discussion_r935994292


##########
test/src/main/java/org/apache/accumulo/test/util/Wait.java:
##########
@@ -0,0 +1,51 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.accumulo.test.util;
+
+import java.util.concurrent.TimeUnit;
+
+public class Wait {
+
+  public static final long MAX_WAIT_MILLIS = 30 * 1000;
+  public static final long SLEEP_MILLIS = 1000;
+
+  public interface Condition {
+    boolean isSatisfied() throws Exception;
+  }
+
+  public static boolean waitFor(Condition condition) throws Exception {
+    return waitFor(condition, MAX_WAIT_MILLIS);
+  }
+
+  public static boolean waitFor(final Condition condition, final long duration) throws Exception {
+    return waitFor(condition, duration, SLEEP_MILLIS);
+  }
+
+  public static boolean waitFor(final Condition condition, final long duration,
+      final long sleepMillis) throws Exception {
+
+    final long expiry = System.currentTimeMillis() + duration;
+    boolean conditionSatisified = condition.isSatisfied();
+    while (!conditionSatisified && System.currentTimeMillis() < expiry) {
+      TimeUnit.MILLISECONDS.sleep(sleepMillis);
+      conditionSatisified = condition.isSatisfied();
+    }
+    return conditionSatisified;

Review Comment:
   Thanks, I can fix this. The utility is actually borrowed from ActiveMQ (another project I work on heavily). Got to love the Apache licensing :)
   
   https://github.com/apache/activemq/blob/f5f1141d36363b137c87b20f11512f9b48057c89/activemq-broker/src/test/java/org/apache/activemq/util/Wait.java
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org