You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@syncope.apache.org by co...@apache.org on 2013/01/29 11:55:14 UTC
svn commit: r1439829 - in /syncope/branches/1_0_X: ./
console/src/main/java/org/apache/syncope/console/pages/ResourceModalPage.java
Author: coheigea
Date: Tue Jan 29 10:55:14 2013
New Revision: 1439829
URL: http://svn.apache.org/viewvc?rev=1439829&view=rev
Log:
Log Resource management exception properly
Modified:
syncope/branches/1_0_X/ (props changed)
syncope/branches/1_0_X/console/src/main/java/org/apache/syncope/console/pages/ResourceModalPage.java
Propchange: syncope/branches/1_0_X/
------------------------------------------------------------------------------
Merged /syncope/trunk:r1439825
Modified: syncope/branches/1_0_X/console/src/main/java/org/apache/syncope/console/pages/ResourceModalPage.java
URL: http://svn.apache.org/viewvc/syncope/branches/1_0_X/console/src/main/java/org/apache/syncope/console/pages/ResourceModalPage.java?rev=1439829&r1=1439828&r2=1439829&view=diff
==============================================================================
--- syncope/branches/1_0_X/console/src/main/java/org/apache/syncope/console/pages/ResourceModalPage.java (original)
+++ syncope/branches/1_0_X/console/src/main/java/org/apache/syncope/console/pages/ResourceModalPage.java Tue Jan 29 10:55:14 2013
@@ -111,7 +111,8 @@ public class ResourceModalPage extends B
window.close(target);
} catch (Exception e) {
- LOG.error("Failuer managing resource {}", resourceTO);
+ LOG.error("Failure managing resource {}", resourceTO);
+ LOG.error("Resource Management Exception:", e);
error(new ResourceModel("error", "error").getObject() + ":" + e.getMessage());
target.add(feedbackPanel);
}
@@ -162,4 +163,4 @@ public class ResourceModalPage extends B
return target;
}
}
-}
\ No newline at end of file
+}
Re: svn commit: r1439829 - in /syncope/branches/1_0_X: ./ console/src/main/java/org/apache/syncope/console/pages/ResourceModalPage.java
Posted by Francesco Chicchiriccò <il...@apache.org>.
On 29/01/2013 12:02, Colm O hEigeartaigh wrote:
> Hi Fabio,
>
> You're right - I'll fix it.
Does it mean you are going to replace "failure" with "failuer" as well? ;-)
--
Francesco Chicchiriccò
ASF Member, Apache Syncope PMC chair, Apache Cocoon PMC Member
http://people.apache.org/~ilgrosso/
Re: svn commit: r1439829 - in /syncope/branches/1_0_X: ./ console/src/main/java/org/apache/syncope/console/pages/ResourceModalPage.java
Posted by Colm O hEigeartaigh <co...@apache.org>.
Hi Fabio,
You're right - I'll fix it.
Colm.
On Tue, Jan 29, 2013 at 10:58 AM, Fabio Martelli
<fa...@gmail.com>wrote:
>
> Il giorno 29/gen/2013, alle ore 11.55, coheigea@apache.org ha scritto:
>
> > Author: coheigea
> > Date: Tue Jan 29 10:55:14 2013
> > New Revision: 1439829
> >
> > URL: http://svn.apache.org/viewvc?rev=1439829&view=rev
> > Log:
> > Log Resource management exception properly
> >
> > Modified:
> > syncope/branches/1_0_X/ (props changed)
> >
> syncope/branches/1_0_X/console/src/main/java/org/apache/syncope/console/pages/ResourceModalPage.java
> >
> > Propchange: syncope/branches/1_0_X/
> >
> ------------------------------------------------------------------------------
> > Merged /syncope/trunk:r1439825
> >
> > Modified:
> syncope/branches/1_0_X/console/src/main/java/org/apache/syncope/console/pages/ResourceModalPage.java
> > URL:
> http://svn.apache.org/viewvc/syncope/branches/1_0_X/console/src/main/java/org/apache/syncope/console/pages/ResourceModalPage.java?rev=1439829&r1=1439828&r2=1439829&view=diff
> >
> ==============================================================================
> > ---
> syncope/branches/1_0_X/console/src/main/java/org/apache/syncope/console/pages/ResourceModalPage.java
> (original)
> > +++
> syncope/branches/1_0_X/console/src/main/java/org/apache/syncope/console/pages/ResourceModalPage.java
> Tue Jan 29 10:55:14 2013
> > @@ -111,7 +111,8 @@ public class ResourceModalPage extends B
> > window.close(target);
> >
> > } catch (Exception e) {
> > - LOG.error("Failuer managing resource {}",
> resourceTO);
> > + LOG.error("Failure managing resource {}",
> resourceTO);
> > + LOG.error("Resource Management Exception:", e);
>
> Hi Colm, why this modification?
> Why not the just the following
>
> LOG.error("Failuer managing resource {}", resourceTO, e);
>
> Best regards,
> F.
>
> > error(new ResourceModel("error",
> "error").getObject() + ":" + e.getMessage());
> > target.add(feedbackPanel);
> > }
> > @@ -162,4 +163,4 @@ public class ResourceModalPage extends B
> > return target;
> > }
> > }
> > -}
> > \ No newline at end of file
> > +}
> >
> >
>
>
--
Colm O hEigeartaigh
Talend Community Coder
http://coders.talend.com
Re: svn commit: r1439829 - in /syncope/branches/1_0_X: ./ console/src/main/java/org/apache/syncope/console/pages/ResourceModalPage.java
Posted by Fabio Martelli <fa...@gmail.com>.
Il giorno 29/gen/2013, alle ore 11.55, coheigea@apache.org ha scritto:
> Author: coheigea
> Date: Tue Jan 29 10:55:14 2013
> New Revision: 1439829
>
> URL: http://svn.apache.org/viewvc?rev=1439829&view=rev
> Log:
> Log Resource management exception properly
>
> Modified:
> syncope/branches/1_0_X/ (props changed)
> syncope/branches/1_0_X/console/src/main/java/org/apache/syncope/console/pages/ResourceModalPage.java
>
> Propchange: syncope/branches/1_0_X/
> ------------------------------------------------------------------------------
> Merged /syncope/trunk:r1439825
>
> Modified: syncope/branches/1_0_X/console/src/main/java/org/apache/syncope/console/pages/ResourceModalPage.java
> URL: http://svn.apache.org/viewvc/syncope/branches/1_0_X/console/src/main/java/org/apache/syncope/console/pages/ResourceModalPage.java?rev=1439829&r1=1439828&r2=1439829&view=diff
> ==============================================================================
> --- syncope/branches/1_0_X/console/src/main/java/org/apache/syncope/console/pages/ResourceModalPage.java (original)
> +++ syncope/branches/1_0_X/console/src/main/java/org/apache/syncope/console/pages/ResourceModalPage.java Tue Jan 29 10:55:14 2013
> @@ -111,7 +111,8 @@ public class ResourceModalPage extends B
> window.close(target);
>
> } catch (Exception e) {
> - LOG.error("Failuer managing resource {}", resourceTO);
> + LOG.error("Failure managing resource {}", resourceTO);
> + LOG.error("Resource Management Exception:", e);
Hi Colm, why this modification?
Why not the just the following
LOG.error("Failuer managing resource {}", resourceTO, e);
Best regards,
F.
> error(new ResourceModel("error", "error").getObject() + ":" + e.getMessage());
> target.add(feedbackPanel);
> }
> @@ -162,4 +163,4 @@ public class ResourceModalPage extends B
> return target;
> }
> }
> -}
> \ No newline at end of file
> +}
>
>