You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "Phabricator (JIRA)" <ji...@apache.org> on 2013/08/14 23:07:48 UTC
[jira] [Updated] (HIVE-5075) bug in ExprProcFactory.genPruner
[ https://issues.apache.org/jira/browse/HIVE-5075?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HIVE-5075:
------------------------------
Attachment: HIVE-5075.D12261.1.patch
sershe requested code review of "HIVE-5075 [jira] bug in ExprProcFactory.genPruner".
Reviewers: JIRA
The code appears to be dead, I am removing the passing-around of this variable from various places.
If the code could/should be used, then the place where it is "returned" should rather be fixed.X
TEST PLAN
EMPTY
REVISION DETAIL
https://reviews.facebook.net/D12261
AFFECTED FILES
ql/src/java/org/apache/hadoop/hive/ql/optimizer/ppr/ExprProcCtx.java
ql/src/java/org/apache/hadoop/hive/ql/optimizer/ppr/ExprProcFactory.java
ql/src/java/org/apache/hadoop/hive/ql/optimizer/ppr/OpProcFactory.java
ql/src/java/org/apache/hadoop/hive/ql/optimizer/ppr/OpWalkerCtx.java
ql/src/java/org/apache/hadoop/hive/ql/optimizer/ppr/PartitionPruner.java
ql/src/java/org/apache/hadoop/hive/ql/parse/ParseContext.java
MANAGE HERALD RULES
https://reviews.facebook.net/herald/view/differential/
WHY DID I GET THIS EMAIL?
https://reviews.facebook.net/herald/transcript/29295/
To: JIRA, sershe
> bug in ExprProcFactory.genPruner
> --------------------------------
>
> Key: HIVE-5075
> URL: https://issues.apache.org/jira/browse/HIVE-5075
> Project: Hive
> Issue Type: Bug
> Reporter: Sergey Shelukhin
> Assignee: Sergey Shelukhin
> Attachments: HIVE-5075.D12261.1.patch
>
>
> The implications are not clear to me yet, I am just familiarizing myself with code around these parts, but ExprProcFactory.genPruner intends to return a value (indicating whether there are non-partition columns) via a primitive boolean parameter.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira