You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by mg...@apache.org on 2012/01/27 10:49:18 UTC
git commit: WICKET-4257 Ajax indicator getting stuck when button is
pressed multiple times
Updated Branches:
refs/heads/wicket-1.5.x c280ba598 -> aeb6f244a
WICKET-4257
Ajax indicator getting stuck when button is pressed multiple times
Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/aeb6f244
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/aeb6f244
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/aeb6f244
Branch: refs/heads/wicket-1.5.x
Commit: aeb6f244a48db0a3667f28e7049cf32e2298e611
Parents: c280ba5
Author: Martin Tzvetanov Grigorov <mg...@apache.org>
Authored: Fri Jan 27 11:48:54 2012 +0200
Committer: Martin Tzvetanov Grigorov <mg...@apache.org>
Committed: Fri Jan 27 11:48:54 2012 +0200
----------------------------------------------------------------------
.../wicket/ajax/AbstractDefaultAjaxBehavior.java | 10 ++++++++++
1 files changed, 10 insertions(+), 0 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/wicket/blob/aeb6f244/wicket-core/src/main/java/org/apache/wicket/ajax/AbstractDefaultAjaxBehavior.java
----------------------------------------------------------------------
diff --git a/wicket-core/src/main/java/org/apache/wicket/ajax/AbstractDefaultAjaxBehavior.java b/wicket-core/src/main/java/org/apache/wicket/ajax/AbstractDefaultAjaxBehavior.java
index 386af7d..48eae31 100644
--- a/wicket-core/src/main/java/org/apache/wicket/ajax/AbstractDefaultAjaxBehavior.java
+++ b/wicket-core/src/main/java/org/apache/wicket/ajax/AbstractDefaultAjaxBehavior.java
@@ -242,6 +242,16 @@ public abstract class AbstractDefaultAjaxBehavior extends AbstractAjaxBehavior
if (precondition != null)
{
buff.append(", function() {");
+ if (Strings.isEmpty(indicatorId) == false)
+ {
+ // WICKET-4257 - ugly way to revert showIncrementally if
+ // the precondition doesn't match after channel postpone
+ buff.append("if (!function() {");
+ buff.append(precondition);
+ buff.append("}.bind(this)()) {Wicket.hideIncrementally('");
+ buff.append(indicatorId);
+ buff.append("');}");
+ }
buff.append(precondition);
buff.append("}.bind(this)");
}