You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by ni...@apache.org on 2021/06/23 10:09:39 UTC

[cordova-plugin-inappbrowser] branch master updated: fix(android): add space between default useragent and custom AppendUserAgent (#861)

This is an automated email from the ASF dual-hosted git repository.

niklasmerz pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cordova-plugin-inappbrowser.git


The following commit(s) were added to refs/heads/master by this push:
     new 9bc8f76  fix(android): add space between default useragent and custom AppendUserAgent (#861)
9bc8f76 is described below

commit 9bc8f7629e486571a62865feaa91016e6631c832
Author: Niklas Merz <ni...@apache.org>
AuthorDate: Wed Jun 23 12:09:27 2021 +0200

    fix(android): add space between default useragent and custom AppendUserAgent (#861)
    
    cordova-android adds a space between the default user agent and the custom one:
    https://github.com/apache/cordova-android/blob/c144c0811249e22f91253ef919cc767f892a8fdf/framework/src/org/apache/cordova/engine/SystemWebViewEngine.java#L214
    
    With this change cordova-androids and the IAB user agent are exactly the same.
---
 src/android/InAppBrowser.java | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/android/InAppBrowser.java b/src/android/InAppBrowser.java
index 479e04c..9a9fc7a 100644
--- a/src/android/InAppBrowser.java
+++ b/src/android/InAppBrowser.java
@@ -970,7 +970,7 @@ public class InAppBrowser extends CordovaPlugin {
                     settings.setUserAgentString(overrideUserAgent);
                 }
                 if (appendUserAgent != null) {
-                    settings.setUserAgentString(settings.getUserAgentString() + appendUserAgent);
+                    settings.setUserAgentString(settings.getUserAgentString() + " " + appendUserAgent);
                 }
 
                 //Toggle whether this is enabled or not!

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org