You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/09/14 19:39:17 UTC

Review Request 68723: Fixed `verify-reviews.py` script to make `-o` optional.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68723/
-----------------------------------------------------------

Review request for mesos and Benjamin Bannier.


Bugs: MESOS-9232
    https://issues.apache.org/jira/browse/MESOS-9232


Repository: mesos


Description
-------

The semantics changed when the ReviewBot scripts were upstreamed; this
makes the `out_file` parameter optional, writing to stdout if not set.


Diffs
-----

  support/verify-reviews.py ce9a35962e82e88648a19d0e8772ba0217ef229d 


Diff: https://reviews.apache.org/r/68723/diff/1/


Testing
-------

Tested with `--skip-verify` on the CLI; argument is no longer required.


Thanks,

Andrew Schwartzmeyer

Re: Review Request 68723: Fixed `verify-reviews.py` script to make `-o` optional.

Posted by Benjamin Bannier <be...@mesosphere.io>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68723/#review208661
-----------------------------------------------------------


Fix it, then Ship it!




LGTM, will fix remaining issues when committing.


support/verify-reviews.py
Line 247 (original), 241 (patched)
<https://reviews.apache.org/r/68723/#comment292778>

    This comment is outdated, suggest to remove.


- Benjamin Bannier


On Sept. 14, 2018, 9:39 p.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68723/
> -----------------------------------------------------------
> 
> (Updated Sept. 14, 2018, 9:39 p.m.)
> 
> 
> Review request for mesos and Benjamin Bannier.
> 
> 
> Bugs: MESOS-9232
>     https://issues.apache.org/jira/browse/MESOS-9232
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The semantics changed when the ReviewBot scripts were upstreamed; this
> makes the `out_file` parameter optional, writing to stdout if not set.
> 
> 
> Diffs
> -----
> 
>   support/verify-reviews.py ce9a35962e82e88648a19d0e8772ba0217ef229d 
> 
> 
> Diff: https://reviews.apache.org/r/68723/diff/1/
> 
> 
> Testing
> -------
> 
> Tested with `--skip-verify` on the CLI; argument is no longer required.
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Re: Review Request 68723: Fixed `verify-reviews.py` script to make `-o` optional.

Posted by Benjamin Bannier <be...@mesosphere.io>.


> On Sept. 14, 2018, 9:40 p.m., Andrew Schwartzmeyer wrote:
> > support/verify-reviews.py
> > Line 253 (original), 246 (patched)
> > <https://reviews.apache.org/r/68723/diff/1/?file=2089109#file2089109line253>
> >
> >     Up to your use of it if you just want silence here instead.

LGTM, dropping.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68723/#review208646
-----------------------------------------------------------


On Sept. 14, 2018, 9:39 p.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68723/
> -----------------------------------------------------------
> 
> (Updated Sept. 14, 2018, 9:39 p.m.)
> 
> 
> Review request for mesos and Benjamin Bannier.
> 
> 
> Bugs: MESOS-9232
>     https://issues.apache.org/jira/browse/MESOS-9232
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The semantics changed when the ReviewBot scripts were upstreamed; this
> makes the `out_file` parameter optional, writing to stdout if not set.
> 
> 
> Diffs
> -----
> 
>   support/verify-reviews.py ce9a35962e82e88648a19d0e8772ba0217ef229d 
> 
> 
> Diff: https://reviews.apache.org/r/68723/diff/1/
> 
> 
> Testing
> -------
> 
> Tested with `--skip-verify` on the CLI; argument is no longer required.
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Re: Review Request 68723: Fixed `verify-reviews.py` script to make `-o` optional.

Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68723/#review208646
-----------------------------------------------------------




support/verify-reviews.py
Line 253 (original), 246 (patched)
<https://reviews.apache.org/r/68723/#comment292751>

    Up to your use of it if you just want silence here instead.


- Andrew Schwartzmeyer


On Sept. 14, 2018, 12:39 p.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68723/
> -----------------------------------------------------------
> 
> (Updated Sept. 14, 2018, 12:39 p.m.)
> 
> 
> Review request for mesos and Benjamin Bannier.
> 
> 
> Bugs: MESOS-9232
>     https://issues.apache.org/jira/browse/MESOS-9232
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The semantics changed when the ReviewBot scripts were upstreamed; this
> makes the `out_file` parameter optional, writing to stdout if not set.
> 
> 
> Diffs
> -----
> 
>   support/verify-reviews.py ce9a35962e82e88648a19d0e8772ba0217ef229d 
> 
> 
> Diff: https://reviews.apache.org/r/68723/diff/1/
> 
> 
> Testing
> -------
> 
> Tested with `--skip-verify` on the CLI; argument is no longer required.
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Re: Review Request 68723: Fixed `verify-reviews.py` script to make `-o` optional.

Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68723/#review208650
-----------------------------------------------------------



PASS: Mesos patch 68723 was successfully built and tested.

Reviews applied: `['68723']`

All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2339/mesos-review-68723

- Mesos Reviewbot Windows


On Sept. 14, 2018, 12:39 p.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68723/
> -----------------------------------------------------------
> 
> (Updated Sept. 14, 2018, 12:39 p.m.)
> 
> 
> Review request for mesos and Benjamin Bannier.
> 
> 
> Bugs: MESOS-9232
>     https://issues.apache.org/jira/browse/MESOS-9232
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The semantics changed when the ReviewBot scripts were upstreamed; this
> makes the `out_file` parameter optional, writing to stdout if not set.
> 
> 
> Diffs
> -----
> 
>   support/verify-reviews.py ce9a35962e82e88648a19d0e8772ba0217ef229d 
> 
> 
> Diff: https://reviews.apache.org/r/68723/diff/1/
> 
> 
> Testing
> -------
> 
> Tested with `--skip-verify` on the CLI; argument is no longer required.
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>