[GitHub] [spark] Ngone51 commented on a change in pull request #27855: [SPARK-31093][SHUFFLE] Fast fail while fetching shuffle data unsuccessfully

[GitBox <gi...@apache.org>]

Ngone51 commented on a change in pull request #27855: [SPARK-31093][SHUFFLE] Fast fail while fetching shuffle data unsuccessfully
URL: https://github.com/apache/spark/pull/27855#discussion_r389699830
 
 

 ##########
 File path: core/src/main/scala/org/apache/spark/storage/ShuffleBlockFetcherIterator.scala
 ##########
 @@ -264,7 +268,7 @@ final class ShuffleBlockFetcherIterator(
 
       override def onBlockFetchFailure(blockId: String, e: Throwable): Unit = {
         logError(s"Failed to get block(s) from ${req.address.host}:${req.address.port}", e)
-        results.put(new FailureFetchResult(BlockId(blockId), infoMap(blockId)._2, address, e))
+        throwFetchFailedException(BlockId(blockId), infoMap(blockId)._2, address, e)
       }
 
 Review comment:
   `onBlockFetchFailure` will be called within Netty's thread. Thus, `ShuffleBlockFetcherIterator` can not catch the exception.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org