[GitHub] bhariharan opened a new pull request #560: GH-559 Fixing dynamic framework installation path

[GitBox <gi...@apache.org>]

bhariharan opened a new pull request #560: GH-559 Fixing dynamic framework installation path
URL: https://github.com/apache/cordova-ios/pull/560
 
 
   ### Platforms affected
   - `cordova-ios 5.0.0`
   
   ### Motivation and Context
   - The newly added dynamic target in the `CordovaLib` project does not get embedded correctly in an app binary. Attempting to build an `IPA` file will throw a `dylib not found` error with `Cordova.framework`.
   - Details in [this GitHub issue](https://github.com/apache/cordova-ios/issues/559).
   
   ### Description
   - Changes are simple and isolated.
   - Added the default base path that's required for a dynamic target.
   
   ### Testing
   - Tested extensively with my own project.
   
   ### Checklist
   - [x] I've run the tests to see all new and existing tests pass
   - [x] I added automated test coverage as appropriate for this change
   - [x] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
   - [x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
   - [x] I've updated the documentation if necessary
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org