You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@arrow.apache.org by "Dominik Moritz (Jira)" <ji...@apache.org> on 2021/05/08 16:54:00 UTC
[jira] [Updated] (ARROW-10221) [JS] toArray() method ignores nulls
on some types.
[ https://issues.apache.org/jira/browse/ARROW-10221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dominik Moritz updated ARROW-10221:
-----------------------------------
Summary: [JS] toArray() method ignores nulls on some types. (was: Javascript toArray() method ignores nulls on some types.)
> [JS] toArray() method ignores nulls on some types.
> --------------------------------------------------
>
> Key: ARROW-10221
> URL: https://issues.apache.org/jira/browse/ARROW-10221
> Project: Apache Arrow
> Issue Type: Bug
> Components: JavaScript
> Affects Versions: 0.17.1
> Reporter: Ben Schmidt
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The .toArray() javascript method of vectors includes a shortcut to return the underlying typed array; but this doesn't respect null values, and so can return the wrong number.
>
> ```
> v = arrow.Vector.from(\{values: [1, 2, 3, 4, 5, null, 6],type: new arrow.Int32()})
> v.toArray()[5] // Incorrectly returns '0'
> v.get(5) // Correctly returns null
> ```
>
> Solution: Eliminate the fast method, always return Javascript arrays. It might be better to keep the old method in cases where there are guaranteed no nulls.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)