You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Vijay (JIRA)" <ji...@apache.org> on 2012/06/07 06:24:23 UTC
[jira] [Created] (CASSANDRA-4315) Use EntryWeigher instead of
Weigher to Measuring the cache.
Vijay created CASSANDRA-4315:
--------------------------------
Summary: Use EntryWeigher instead of Weigher to Measuring the cache.
Key: CASSANDRA-4315
URL: https://issues.apache.org/jira/browse/CASSANDRA-4315
Project: Cassandra
Issue Type: Improvement
Components: Core
Affects Versions: 1.2
Reporter: Vijay
Assignee: Vijay
Fix For: 1.2
This ticket is a followup for CASSANDRA-4150.
CLHM 1.3 added EntryWeigher which will help us accurately measure the size of the
It might be useful to add Key capacity (In-Heap Overhead) vs off-heap capacity for serializing cache (To avoid OOM's for a long Row Keys).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-4315) Use EntryWeigher instead of
Weigher to Measuring the cache.
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4315?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-4315:
--------------------------------------
Reviewer: jbellis
Priority: Minor (was: Major)
> Use EntryWeigher instead of Weigher to Measuring the cache.
> -----------------------------------------------------------
>
> Key: CASSANDRA-4315
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4315
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Affects Versions: 1.2
> Reporter: Vijay
> Assignee: Vijay
> Priority: Minor
> Fix For: 1.2
>
> Attachments: 0001-CASSANDRA-4315.patch
>
>
> This ticket is a followup for CASSANDRA-4150.
> CLHM 1.3 added EntryWeigher which will help us accurately measure the size of the
> It might be useful to add Key capacity (In-Heap Overhead) vs off-heap capacity for serializing cache (To avoid OOM's for a long Row Keys).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4315) Use EntryWeigher instead of
Weigher to Measuring the cache.
Posted by "Vijay (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13290787#comment-13290787 ]
Vijay commented on CASSANDRA-4315:
----------------------------------
We also might want to use MemoryMeter for KeyCache.put() too, with Promoted index in the mix KeyCache no longer honers AVERAGE_KEY_CACHE_ROW_SIZE of 48 bytes.
> Use EntryWeigher instead of Weigher to Measuring the cache.
> -----------------------------------------------------------
>
> Key: CASSANDRA-4315
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4315
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Affects Versions: 1.2
> Reporter: Vijay
> Assignee: Vijay
> Fix For: 1.2
>
>
> This ticket is a followup for CASSANDRA-4150.
> CLHM 1.3 added EntryWeigher which will help us accurately measure the size of the
> It might be useful to add Key capacity (In-Heap Overhead) vs off-heap capacity for serializing cache (To avoid OOM's for a long Row Keys).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-4315) Use EntryWeigher instead of
Weigher to Measuring the cache.
Posted by "Vijay (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4315?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Vijay updated CASSANDRA-4315:
-----------------------------
Attachment: 0001-CASSANDRA-4315.patch
> Use EntryWeigher instead of Weigher to Measuring the cache.
> -----------------------------------------------------------
>
> Key: CASSANDRA-4315
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4315
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Affects Versions: 1.2
> Reporter: Vijay
> Assignee: Vijay
> Fix For: 1.2
>
> Attachments: 0001-CASSANDRA-4315.patch
>
>
> This ticket is a followup for CASSANDRA-4150.
> CLHM 1.3 added EntryWeigher which will help us accurately measure the size of the
> It might be useful to add Key capacity (In-Heap Overhead) vs off-heap capacity for serializing cache (To avoid OOM's for a long Row Keys).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (CASSANDRA-4315) Use EntryWeigher instead
of Weigher to Measuring the cache.
Posted by "Vijay (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13290787#comment-13290787 ]
Vijay edited comment on CASSANDRA-4315 at 6/7/12 4:31 AM:
----------------------------------------------------------
We also might want to use MemoryMeter for KeyCache.put() too, with Promoted index in 1.2... KeyCache no longer honers AVERAGE_KEY_CACHE_ROW_SIZE of 48 bytes.
was (Author: vijay2win@yahoo.com):
We also might want to use MemoryMeter for KeyCache.put() too, with Promoted index in the mix KeyCache no longer honers AVERAGE_KEY_CACHE_ROW_SIZE of 48 bytes.
> Use EntryWeigher instead of Weigher to Measuring the cache.
> -----------------------------------------------------------
>
> Key: CASSANDRA-4315
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4315
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Affects Versions: 1.2
> Reporter: Vijay
> Assignee: Vijay
> Fix For: 1.2
>
>
> This ticket is a followup for CASSANDRA-4150.
> CLHM 1.3 added EntryWeigher which will help us accurately measure the size of the
> It might be useful to add Key capacity (In-Heap Overhead) vs off-heap capacity for serializing cache (To avoid OOM's for a long Row Keys).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4315) Use EntryWeigher instead of
Weigher to Measuring the cache.
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13295334#comment-13295334 ]
Jonathan Ellis commented on CASSANDRA-4315:
-------------------------------------------
LGTM, +1.
Nit: looks like ConcurrentLinkedHashCache constructor was made public unnecessarily
Nit 2: would like to log a warning if MM is unavailable
> Use EntryWeigher instead of Weigher to Measuring the cache.
> -----------------------------------------------------------
>
> Key: CASSANDRA-4315
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4315
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Affects Versions: 1.2
> Reporter: Vijay
> Assignee: Vijay
> Fix For: 1.2
>
> Attachments: 0001-CASSANDRA-4315.patch
>
>
> This ticket is a followup for CASSANDRA-4150.
> CLHM 1.3 added EntryWeigher which will help us accurately measure the size of the
> It might be useful to add Key capacity (In-Heap Overhead) vs off-heap capacity for serializing cache (To avoid OOM's for a long Row Keys).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira