You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "Loyal-Young (via GitHub)" <gi...@apache.org> on 2026/10/17 09:56:43 UTC
[PR] docs(deploy): describe demo clients NameServer connection [rocketmq-dashboard]
Loyal-Young opened a new pull request, #6911:
URL: https://github.com/apache/rocketmq-dashboard/pull/6911
## What is the purpose of the change
Fixes #5970. The local deployment README said both bundled traffic generators connect through `proxy:8080`, but both Java clients call `setNamesrvAddr` with `NAMESRV_ADDR`, and Compose sets that variable to `rmq-nameserver:9876`.
The earlier PR #5971 was automatically closed after inactivity without merging. This documentation correction is based on the current clients and Compose file.
## Brief changelog
- Correct the directory listing to say the producer and consumer connect to NameServer.
- Clarify that bundled traffic does not exercise the Proxy endpoint, so Proxy traffic requires a separate client.
## Verification
- Checked both Java clients' `setNamesrvAddr` calls and both Compose `NAMESRV_ADDR` entries against the README.
- `git diff --check`: passed.
## AI assistance
AI assistance helped compare the README with the bundled Java clients and Compose configuration and draft the corrected wording. I reviewed the cited source lines and the final diff.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] docs(deploy): describe demo clients NameServer connection [rocketmq-dashboard]
Posted by "Loyal-Young (via GitHub)" <gi...@apache.org>.
Loyal-Young commented on PR #6911:
URL: https://github.com/apache/rocketmq-dashboard/pull/6911#issuecomment-6261579510
Progress update (2026-10-19): GitHub currently reports the branch as mergeable. All five current CI checks pass. The change is ready for maintainer review. I will follow up on any new feedback.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] docs(deploy): describe demo clients NameServer connection [rocketmq-dashboard]
Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins commented on PR #6911:
URL: https://github.com/apache/rocketmq-dashboard/pull/6911#issuecomment-6266490555
Folded into #6707, merged into `rocketmq-studio` as fbdc5f22b — your change is in that commit and stays authored by you.
We batched five related AI / a11y / user-management / docs PRs (#6707 #6469 #6908 #6902 #6911) into a single integration commit to keep the history readable, so this one is closed as folded rather than merged separately. No action needed; the linked issue is closed as resolved by #6707.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] docs(deploy): describe demo clients NameServer connection [rocketmq-dashboard]
Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins closed pull request #6911: docs(deploy): describe demo clients NameServer connection
URL: https://github.com/apache/rocketmq-dashboard/pull/6911
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org