You are viewing a plain text version of this content. The canonical link for it is here.
Posted to c-dev@axis.apache.org by Samisa Abeysinghe <sa...@gmail.com> on 2006/05/24 17:57:49 UTC
[Axis2][Fwd: svn commit: r409189 - /webservices/axis2/trunk/c/util/include/axis2_dir_handler.h]
There is a problem in this commit as well.
1. It is missing the env parameter as per the convention
2. IMHO the function name should be axis2_extract_arr and not
axis2_aar_extract
3. given that the function is in axis2_dir_handler.h we should have
axis2_dir_handler_ as the prefix
4. Why is it not give axis2_dir_handler struct as a parameter? If it is
not required, why should this function be here in this header?
Thanks,
Samisa...
-------- Original Message --------
Subject: svn commit: r409189 -
/webservices/axis2/trunk/c/util/include/axis2_dir_handler.h
Date: Wed, 24 May 2006 15:15:45 -0000
From: pini@apache.org
To: axis2-cvs@ws.apache.org
Author: pini
Date: Wed May 24 08:15:45 2006
New Revision: 409189
URL: http://svn.apache.org/viewvc?rev=409189&view=rev
Log:
changes to archive based deployment model
Modified:
webservices/axis2/trunk/c/util/include/axis2_dir_handler.h
Modified: webservices/axis2/trunk/c/util/include/axis2_dir_handler.h
URL: http://svn.apache.org/viewvc/webservices/axis2/trunk/c/util/include/axis2_dir_handler.h?rev=409189&r1=409188&r2=409189&view=diff
==============================================================================
--- webservices/axis2/trunk/c/util/include/axis2_dir_handler.h (original)
+++ webservices/axis2/trunk/c/util/include/axis2_dir_handler.h Wed May 24 08:15:45 2006
@@ -53,6 +53,15 @@
AXIS2_DECLARE(axis2_array_list_t *)
axis2_dir_handler_list_service_or_module_dirs(axis2_env_t **env,
axis2_char_t *pathname);
+
+ /**
+ * * Extract the archives in services and modules directories
+ * * */
+
+ AXIS2_DECLARE(axis2_status_t *)
+ axis2_aar_extract();
+
+
/***********************Function Macros****************************************/
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-cvs-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-cvs-help@ws.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-c-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-c-dev-help@ws.apache.org
Re: [Axis2][Fwd: svn commit: r409189 - /webservices/axis2/trunk/c/util/include/axis2_dir_handler.h]
Posted by Sanjaya Ratnaweera <sa...@wso2.com>.
Samisa Abeysinghe wrote:
> There is a problem in this commit as well.
> 1. It is missing the env parameter as per the convention
> 2. IMHO the function name should be axis2_extract_arr and not
> axis2_aar_extract
> 3. given that the function is in axis2_dir_handler.h we should have
> axis2_dir_handler_ as the prefix
> 4. Why is it not give axis2_dir_handler struct as a parameter? If it
> is not required, why should this function be here in this header?
yes. It's not necessary to keep it in header. Removed it.
Thanks.
~sanjaya
>
> Thanks,
> Samisa...
>
> -------- Original Message --------
> Subject: svn commit: r409189 -
> /webservices/axis2/trunk/c/util/include/axis2_dir_handler.h
> Date: Wed, 24 May 2006 15:15:45 -0000
> From: pini@apache.org
> To: axis2-cvs@ws.apache.org
>
>
>
> Author: pini
> Date: Wed May 24 08:15:45 2006
> New Revision: 409189
>
> URL: http://svn.apache.org/viewvc?rev=409189&view=rev
> Log:
> changes to archive based deployment model
>
> Modified:
> webservices/axis2/trunk/c/util/include/axis2_dir_handler.h
>
> Modified: webservices/axis2/trunk/c/util/include/axis2_dir_handler.h
> URL:
> http://svn.apache.org/viewvc/webservices/axis2/trunk/c/util/include/axis2_dir_handler.h?rev=409189&r1=409188&r2=409189&view=diff
>
> ==============================================================================
>
> --- webservices/axis2/trunk/c/util/include/axis2_dir_handler.h (original)
> +++ webservices/axis2/trunk/c/util/include/axis2_dir_handler.h Wed May
> 24 08:15:45 2006
> @@ -53,6 +53,15 @@
> AXIS2_DECLARE(axis2_array_list_t *)
> axis2_dir_handler_list_service_or_module_dirs(axis2_env_t **env,
> axis2_char_t *pathname);
> +
> + /**
> + * * Extract the archives in services and modules directories
> + * * */
> +
> + AXIS2_DECLARE(axis2_status_t *)
> + axis2_aar_extract();
> +
> +
> /***********************Function
> Macros****************************************/
>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: axis-cvs-unsubscribe@ws.apache.org
> For additional commands, e-mail: axis-cvs-help@ws.apache.org
>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: axis-c-dev-unsubscribe@ws.apache.org
> For additional commands, e-mail: axis-c-dev-help@ws.apache.org
>
>
--
http://www.araliya.net
http://sanjayar.googlepages.com
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-c-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-c-dev-help@ws.apache.org