[GitHub] [incubator-pinot] npawar commented on a change in pull request #4376: Config for overriding initial rows threshold in segment size auto tuning

[GitBox <gi...@apache.org>]

npawar commented on a change in pull request #4376: Config for overriding initial rows threshold in segment size auto tuning
URL: https://github.com/apache/incubator-pinot/pull/4376#discussion_r298669766
 
 

 ##########
 File path: pinot-core/src/main/java/org/apache/pinot/core/realtime/stream/StreamConfig.java
 ##########
 @@ -197,6 +199,19 @@ public StreamConfig(Map<String, String> streamConfigMap) {
       _flushSegmentDesiredSizeBytes = DEFAULT_DESIRED_SEGMENT_SIZE_BYTES;
     }
 
+    int initialRowsThreshold = 0;
+    String initialRowsThresholdValue = streamConfigMap.get(StreamConfigProperties.SEGMENT_INITIAL_ROWS_THRESHOLD);
+    if (initialRowsThresholdValue != null) {
+      try {
+        initialRowsThreshold = Integer.parseInt(initialRowsThresholdValue);
 
 Review comment:
   I've checked for positive, 2 lines below this. I dont think we should check for some minimum value... it might backfire in some cases if threshold was actually expected to be small

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org