You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by Kevin Risden <co...@gmail.com> on 2016/05/11 15:31:18 UTC

Lucene/Solr JIRA Fix Version question

I performed the following JIRA search and found ~955 issues:

project in (SOLR,LUCENE) and status in (Open) and fixVersion IS NOT EMPTY

Does it make sense that there are so many issues that are open and have a
fixVersion that is not empty?

I think these issues fall into a few categories (may have missed a few
cases):

* Fix Version < 6.0 - should either be resolved or have the fix version
removed since < 6.0 was released
* Fix Version == 6.0 - should be resolved or have the fix version removed
(most of the cases due to LUCENE-7271)
* Fix Version == 6.1 - assuming these are currently being worked on or
resolved if committed?
* Fix Version == master (7.0) - resolve or remove fix version?

Since LUCENE-7271 was completed, I think that it shows the problem a bit
more clearly. It looks like previously Fix Version == master was just used
arbitrarily to indicate some point in the future.

Kevin Risden

Re: Lucene/Solr JIRA Fix Version question

Posted by Kevin Risden <co...@gmail.com>.
There will be a few false positives for these two JIRA queries (commits
that didn't fully fix the issue) but the three I listed above are there:

Check for Git commit:

project in (SOLR, LUCENE) AND status in (Open) and fixVersion is not empty
and text ~ "in lucene-solr's branch refs/heads/" order by updated

Check for older SVN commit:

project in (SOLR, LUCENE) AND status in (Open) and fixVersion is not empty
and text ~ "in branch 'dev/trunk'" order by updated

Kevin Risden

On Wed, May 11, 2016 at 12:07 PM, Kevin Risden <co...@gmail.com>
wrote:

> Here are three that I just happened upon and was semi familiar with:
> * SOLR-8097
> * SOLR-9058
> * SOLR-8878
>
> Looks like they just need to be resolved properly and fix the fixVersion.
>
> there might be just as many open issues w/o a fixVersion that warrant
>> equal review/edits.
>
>
> Yea that is probably true. I The recent work on JIRA and "Street Light
> Effect" as you say can be good to get JIRA cleaned up further :)
>
> I don't plan on putting much effort into it currently but definitely
> opened my eyes to what more can be done.
>
> Kevin Risden
>
> On Wed, May 11, 2016 at 11:49 AM, Chris Hostetter <
> hossman_lucene@fucit.org> wrote:
>
>>
>> : I wasn't suggesting a blanket resolve of issues. There are a few that I
>> : looked at that should have been resolved and weren't. This would require
>> : some manual effort.
>>
>> can you give some examples?
>>
>> I was reading "resolved" as "FIXED" but if you're talking about issues
>> that could/should be marked WONT_FIX or CANT_REPRO or DUP then i suspect
>> you're just falling for the "Street Light Effect" ... the recent work and
>> 6.0 happened to catch your eye, and you notice some of those open 6.0
>> issues could/should be resolved, but that doesn't mean there is anything
>> special about open issues with 6.0 set on them ... there might be just as
>> many open issues w/o a fixVersion that warrant equal review/edits.
>>
>> : Since there isn't a problem here that open and fixVersion doesn't mean
>> : anything together, I'm fine with just leaving as is.
>>
>> I don't think there is, and i don't subscribe any meaning to it, but
>> that's just my opinion.
>>
>> if other folks *want* to subscribe meaning to it that will be an uphill
>> battle unless some work is done to change our workflow and lock down jira
>> to prevent arbitrary fixVersons from bieng added to issues.
>>
>>
>> -Hoss
>> http://www.lucidworks.com/
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
>> For additional commands, e-mail: dev-help@lucene.apache.org
>>
>>
>

Re: Lucene/Solr JIRA Fix Version question

Posted by Kevin Risden <co...@gmail.com>.
Here are three that I just happened upon and was semi familiar with:
* SOLR-8097
* SOLR-9058
* SOLR-8878

Looks like they just need to be resolved properly and fix the fixVersion.

there might be just as many open issues w/o a fixVersion that warrant equal
> review/edits.


Yea that is probably true. I The recent work on JIRA and "Street Light
Effect" as you say can be good to get JIRA cleaned up further :)

I don't plan on putting much effort into it currently but definitely opened
my eyes to what more can be done.

Kevin Risden

On Wed, May 11, 2016 at 11:49 AM, Chris Hostetter <ho...@fucit.org>
wrote:

>
> : I wasn't suggesting a blanket resolve of issues. There are a few that I
> : looked at that should have been resolved and weren't. This would require
> : some manual effort.
>
> can you give some examples?
>
> I was reading "resolved" as "FIXED" but if you're talking about issues
> that could/should be marked WONT_FIX or CANT_REPRO or DUP then i suspect
> you're just falling for the "Street Light Effect" ... the recent work and
> 6.0 happened to catch your eye, and you notice some of those open 6.0
> issues could/should be resolved, but that doesn't mean there is anything
> special about open issues with 6.0 set on them ... there might be just as
> many open issues w/o a fixVersion that warrant equal review/edits.
>
> : Since there isn't a problem here that open and fixVersion doesn't mean
> : anything together, I'm fine with just leaving as is.
>
> I don't think there is, and i don't subscribe any meaning to it, but
> that's just my opinion.
>
> if other folks *want* to subscribe meaning to it that will be an uphill
> battle unless some work is done to change our workflow and lock down jira
> to prevent arbitrary fixVersons from bieng added to issues.
>
>
> -Hoss
> http://www.lucidworks.com/
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: dev-help@lucene.apache.org
>
>

Re: Lucene/Solr JIRA Fix Version question

Posted by Chris Hostetter <ho...@fucit.org>.
: I wasn't suggesting a blanket resolve of issues. There are a few that I
: looked at that should have been resolved and weren't. This would require
: some manual effort.

can you give some examples?

I was reading "resolved" as "FIXED" but if you're talking about issues 
that could/should be marked WONT_FIX or CANT_REPRO or DUP then i suspect 
you're just falling for the "Street Light Effect" ... the recent work and 
6.0 happened to catch your eye, and you notice some of those open 6.0 
issues could/should be resolved, but that doesn't mean there is anything 
special about open issues with 6.0 set on them ... there might be just as 
many open issues w/o a fixVersion that warrant equal review/edits.

: Since there isn't a problem here that open and fixVersion doesn't mean
: anything together, I'm fine with just leaving as is.

I don't think there is, and i don't subscribe any meaning to it, but 
that's just my opinion.

if other folks *want* to subscribe meaning to it that will be an uphill 
battle unless some work is done to change our workflow and lock down jira 
to prevent arbitrary fixVersons from bieng added to issues.


-Hoss
http://www.lucidworks.com/

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Re: Lucene/Solr JIRA Fix Version question

Posted by Kevin Risden <co...@gmail.com>.
> TLDR: I don't think it's worth any time/effort to worry about fixVersion
> for open issues.
>

Thats fair and your explanation makes a lot of sense.

I'm not sure why you think it would be a good idea to blanket resolve
> issues with older fix versions -- that seems to be confusing cause with
> effect (ie: just because someone set the fixVersion=6.0 doesn't mean the
> bug was magically fixed or a feature was magically added)


I wasn't suggesting a blanket resolve of issues. There are a few that I
looked at that should have been resolved and weren't. This would require
some manual effort.

The reason I did that search was I saw a bunch of issues now have the
fixVersion as 6.0 even when they are still open. I never really took a
second look at the issues before since many of them were master and are now
fixVersion==6.0.

Since there isn't a problem here that open and fixVersion doesn't mean
anything together, I'm fine with just leaving as is.

Kevin Risden

Re: Lucene/Solr JIRA Fix Version question

Posted by Chris Hostetter <ho...@fucit.org>.
TLDR: I don't think it's worth any time/effort to worry about fixVersion 
for open issues.


: project in (SOLR,LUCENE) and status in (Open) and fixVersion IS NOT EMPTY
: 
: Does it make sense that there are so many issues that are open and have a
: fixVersion that is not empty?

Yes, there are lots of reasons why an Open issue might have a fixVersion 
set -- it's not really an indication of a problem.  When folks resolve 
issues, that's when it's really important to make sure the fixVersion is 
set correctly.

Typically what happens is...

1) the person who filed the issue ambitiously/optimistically 
set the fixVersion to a particular X.Y in the *hope* that it 
would be fixed in that version, and it's never been updated since.

OR

2) people actively working on an issue set the fixVersion to help remind 
themselves, or signal to others, that they intend to backport to 
particular branches in time for particular releases.

...but it's not really obvious from any particular jira search when/why a 
bunch of issues have a particular fixVersion, you have to look at 
individual issues.

: I think these issues fall into a few categories (may have missed a few
: cases):
: 
: * Fix Version < 6.0 - should either be resolved or have the fix version
: removed since < 6.0 was released
: * Fix Version == 6.0 - should be resolved or have the fix version removed
: (most of the cases due to LUCENE-7271)
: * Fix Version == 6.1 - assuming these are currently being worked on or
: resolved if committed?
: * Fix Version == master (7.0) - resolve or remove fix version?

I'm not sure why you think it would be a good idea to blanket resolve 
issues with older fix versions -- that seems to be confusing cause with 
effect (ie: just because someone set the fixVersion=6.0 doesn't mean the 
bug was magically fixed or a feature was magically added)

If you are looking to make a bulk change I suppose we could just wipe the 
fixVersion from all unresolved issues, but that seems like trying to bail 
out a boat with a massive hole in the bottom using an even more 
massive bucket -- you might get all the water out today, but there won't 
be naything to stop the flood of water that comes in on a regular basis.


-Hoss
http://www.lucidworks.com/

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org