You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/06/20 12:02:25 UTC
[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6465: Add lcd_dev_s pointer to lcd_planeinfo_s to support multiple LCDs per board
pkarashchenko commented on code in PR #6465:
URL: https://github.com/apache/incubator-nuttx/pull/6465#discussion_r901577528
##########
include/nuttx/lcd/lcd.h:
##########
@@ -139,6 +145,12 @@ struct lcd_planeinfo_s
*/
uint8_t bpp;
+
+ /* This is the LCD interface corresponding to which this color plane
+ * belongs.
+ */
+
+ struct lcd_dev_s *dev;
Review Comment:
```suggestion
FAR struct lcd_dev_s *dev;
```
##########
drivers/lcd/st7567.c:
##########
@@ -555,14 +556,12 @@ static int st7567_putrun(fb_coord_t row, fb_coord_t col,
*
****************************************************************************/
-static int st7567_getrun(fb_coord_t row, fb_coord_t col, FAR uint8_t *buffer,
- size_t npixels)
+static int st7567_getrun(struct lcd_dev_s *dev,
Review Comment:
```suggestion
static int st7567_getrun(FAR struct lcd_dev_s *dev,
```
##########
drivers/lcd/st7567.c:
##########
@@ -224,10 +224,12 @@ static void st7567_deselect(FAR struct spi_dev_s *spi);
/* LCD Data Transfer Methods */
-static int st7567_putrun(fb_coord_t row, fb_coord_t col,
+static int st7567_putrun(struct lcd_dev_s *dev,
Review Comment:
```suggestion
static int st7567_putrun(FAR struct lcd_dev_s *dev,
```
##########
drivers/lcd/p14201.c:
##########
@@ -809,11 +813,12 @@ static int rit_putrun(fb_coord_t row, fb_coord_t col,
return OK;
}
#else
-static int rit_putrun(fb_coord_t row, fb_coord_t col,
+static int rit_putrun(struct lcd_dev_s *dev,
Review Comment:
```suggestion
static int rit_putrun(FAR struct lcd_dev_s *dev,
```
##########
drivers/lcd/mio283qt9a.c:
##########
@@ -166,10 +166,12 @@ static void mio283qt9a_setarea(FAR struct mio283qt9a_lcd_s *lcd,
/* LCD Data Transfer Methods */
-static int mio283qt9a_putrun(fb_coord_t row, fb_coord_t col,
+static int mio283qt9a_putrun(struct lcd_dev_s *dev,
+ fb_coord_t row, fb_coord_t col,
FAR const uint8_t *buffer,
size_t npixels);
-static int mio283qt9a_getrun(fb_coord_t row, fb_coord_t col,
+static int mio283qt9a_getrun(struct lcd_dev_s *dev,
Review Comment:
```suggestion
static int mio283qt9a_getrun(FAR struct lcd_dev_s *dev,
```
##########
drivers/lcd/mio283qt2.c:
##########
@@ -521,11 +522,12 @@ static void mio283qt2_dumprun(FAR const char *msg,
*
****************************************************************************/
-static int mio283qt2_putrun(fb_coord_t row, fb_coord_t col,
+static int mio283qt2_putrun(struct lcd_dev_s *dev,
Review Comment:
```suggestion
static int mio283qt2_putrun(FAR struct lcd_dev_s *dev,
```
##########
drivers/lcd/ili9341.c:
##########
@@ -660,7 +621,7 @@ static int ili9341_putrun(int devno, fb_coord_t row, fb_coord_t col,
* Read a partial raster line from the LCD.
*
* Input Parameters:
- * devno - Number of the lcd device
+ * devno - The lcd device
Review Comment:
```suggestion
* lcd_dev - The lcd device
```
##########
drivers/lcd/st7567.c:
##########
@@ -403,15 +406,12 @@ static void st7567_deselect(FAR struct spi_dev_s *spi)
*
****************************************************************************/
-static int st7567_putrun(fb_coord_t row, fb_coord_t col,
+static int st7567_putrun(struct lcd_dev_s *dev,
Review Comment:
```suggestion
static int st7567_putrun(FAR struct lcd_dev_s *dev,
```
##########
drivers/lcd/st7567.c:
##########
@@ -224,10 +224,12 @@ static void st7567_deselect(FAR struct spi_dev_s *spi);
/* LCD Data Transfer Methods */
-static int st7567_putrun(fb_coord_t row, fb_coord_t col,
+static int st7567_putrun(struct lcd_dev_s *dev,
+ fb_coord_t row, fb_coord_t col,
FAR const uint8_t *buffer,
size_t npixels);
-static int st7567_getrun(fb_coord_t row, fb_coord_t col,
+static int st7567_getrun(struct lcd_dev_s *dev,
Review Comment:
```suggestion
static int st7567_getrun(FAR struct lcd_dev_s *dev,
```
##########
drivers/lcd/p14201.c:
##########
@@ -643,11 +646,12 @@ static inline void rit_clear(FAR struct rit_dev_s *priv)
****************************************************************************/
#ifdef CONFIG_P14201_FRAMEBUFFER
-static int rit_putrun(fb_coord_t row, fb_coord_t col,
+static int rit_putrun(struct lcd_dev_s *dev,
Review Comment:
```suggestion
static int rit_putrun(FAR struct lcd_dev_s *dev,
```
##########
drivers/lcd/p14201.c:
##########
@@ -201,10 +201,12 @@ static void rit_sndcmds(FAR struct rit_dev_s *priv,
/* LCD Data Transfer Methods */
-static int rit_putrun(fb_coord_t row, fb_coord_t col,
+static int rit_putrun(struct lcd_dev_s *dev,
Review Comment:
```suggestion
static int rit_putrun(FAR struct lcd_dev_s *dev,
```
##########
drivers/lcd/mio283qt9a.c:
##########
@@ -472,15 +475,17 @@ static int mio283qt9a_putrun(fb_coord_t row, fb_coord_t col,
*
****************************************************************************/
-static int mio283qt9a_getrun(fb_coord_t row, fb_coord_t col,
+static int mio283qt9a_getrun(struct lcd_dev_s *dev,
Review Comment:
```suggestion
static int mio283qt9a_getrun(FAR struct lcd_dev_s *dev,
```
##########
drivers/lcd/p14201.c:
##########
@@ -201,10 +201,12 @@ static void rit_sndcmds(FAR struct rit_dev_s *priv,
/* LCD Data Transfer Methods */
-static int rit_putrun(fb_coord_t row, fb_coord_t col,
+static int rit_putrun(struct lcd_dev_s *dev,
+ fb_coord_t row, fb_coord_t col,
FAR const uint8_t *buffer,
size_t npixels);
-static int rit_getrun(fb_coord_t row, fb_coord_t col,
+static int rit_getrun(struct lcd_dev_s *dev,
Review Comment:
```suggestion
static int rit_getrun(FAR struct lcd_dev_s *dev,
```
##########
drivers/lcd/mio283qt2.c:
##########
@@ -570,12 +573,13 @@ static int mio283qt2_putrun(fb_coord_t row, fb_coord_t col,
*
****************************************************************************/
-static int mio283qt2_getrun(fb_coord_t row, fb_coord_t col,
+static int mio283qt2_getrun(struct lcd_dev_s *dev,
Review Comment:
```suggestion
static int mio283qt2_getrun(FAR struct lcd_dev_s *dev,
```
##########
drivers/lcd/mio283qt9a.c:
##########
@@ -166,10 +166,12 @@ static void mio283qt9a_setarea(FAR struct mio283qt9a_lcd_s *lcd,
/* LCD Data Transfer Methods */
-static int mio283qt9a_putrun(fb_coord_t row, fb_coord_t col,
+static int mio283qt9a_putrun(struct lcd_dev_s *dev,
Review Comment:
```suggestion
static int mio283qt9a_putrun(FAR struct lcd_dev_s *dev,
```
##########
drivers/lcd/mio283qt9a.c:
##########
@@ -424,11 +425,12 @@ static void mio283qt9a_dumprun(FAR const char *msg,
*
****************************************************************************/
-static int mio283qt9a_putrun(fb_coord_t row, fb_coord_t col,
+static int mio283qt9a_putrun(struct lcd_dev_s *dev,
Review Comment:
```suggestion
static int mio283qt9a_putrun(FAR struct lcd_dev_s *dev,
```
##########
drivers/lcd/mio283qt2.c:
##########
@@ -281,10 +281,12 @@ static void mio283qt2_setarea(FAR struct mio283qt2_lcd_s *lcd,
/* LCD Data Transfer Methods */
-static int mio283qt2_putrun(fb_coord_t row, fb_coord_t col,
+static int mio283qt2_putrun(struct lcd_dev_s *dev,
+ fb_coord_t row, fb_coord_t col,
FAR const uint8_t *buffer,
size_t npixels);
-static int mio283qt2_getrun(fb_coord_t row, fb_coord_t col,
+static int mio283qt2_getrun(struct lcd_dev_s *dev,
Review Comment:
```suggestion
static int mio283qt2_getrun(FAR struct lcd_dev_s *dev,
```
##########
drivers/lcd/mio283qt2.c:
##########
@@ -281,10 +281,12 @@ static void mio283qt2_setarea(FAR struct mio283qt2_lcd_s *lcd,
/* LCD Data Transfer Methods */
-static int mio283qt2_putrun(fb_coord_t row, fb_coord_t col,
+static int mio283qt2_putrun(struct lcd_dev_s *dev,
Review Comment:
```suggestion
static int mio283qt2_putrun(FAR struct lcd_dev_s *dev,
```
##########
drivers/lcd/ili9341.c:
##########
@@ -600,7 +560,7 @@ static void ili9341_selectarea(FAR struct ili9341_lcd_s *lcd,
* Write a partial raster line to the LCD.
*
* Input Parameters:
- * devno - Number of lcd device
+ * dev - The lcd device
Review Comment:
```suggestion
* lcd_dev - The lcd device
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org