[jira] [Commented] (METRON-1541) Mvn clean results in git status having deleted files.

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/METRON-1541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16456315#comment-16456315 ] 

ASF GitHub Bot commented on METRON-1541:
----------------------------------------

GitHub user justinleet opened a pull request:

    https://github.com/apache/metron/pull/1003

    METRON-1541: Mvn clean results in git status having deleted files.

    ## Contributor Comments
    Run
    `mvn clean`
    
    then run
    `git status`
    
    Status should be clean with no deleted files.
    
    ## Pull Request Checklist
    
    Thank you for submitting a contribution to Apache Metron.  
    Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235) for the complete guide to follow for contributions.  
    Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview) for complete smoke testing guides.  
    
    
    In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
    - [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    - [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    
    ### For code changes:
    - [x] Have you included steps to reproduce the behavior or problem that is being changed or addressed?
    - [x] Have you included steps or a guide to how the change may be verified and tested manually?
    - [ ] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:
      ```
      mvn -q clean integration-test install && dev-utilities/build-utils/verify_licenses.sh 
      ```
    
    - [ ] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?
    
    #### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
    It is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal repository such that your branches are built there before submitting a pull request.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/justinleet/metron METRON-1541

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/metron/pull/1003.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1003
    
----
commit 5e5afe6f8e48ea29fdc0be84f0a3a8794b925e38
Author: justinjleet <ju...@...>
Date:   2018-04-27T12:41:25Z

    Deleting files and adding them to gitignore to match similar enrichment j2 files

----


> Mvn clean results in git status having deleted files.
> -----------------------------------------------------
>
>                 Key: METRON-1541
>                 URL: https://issues.apache.org/jira/browse/METRON-1541
>             Project: Metron
>          Issue Type: Bug
>            Reporter: Justin Leet
>            Priority: Minor
>
> When you run mvn clean, you end up with the following git status.
> deleted: metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/package/templates/enrichment-splitjoin.properties.j2
>  deleted: metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/package/templates/enrichment-unified.properties.j2
>  
> These files should likely be in the .gitignore and deleted from source control.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)