You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/03/18 14:11:48 UTC
[GitHub] [camel-quarkus] ppalaga opened a new pull request #903: POM
enhancements
ppalaga opened a new pull request #903: POM enhancements
URL: https://github.com/apache/camel-quarkus/pull/903
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on issue #903: POM enhancements
Posted by GitBox <gi...@apache.org>.
ppalaga commented on issue #903: POM enhancements
URL: https://github.com/apache/camel-quarkus/pull/903#issuecomment-600761508
Approved by @jamesnetherton
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] ppalaga merged pull request #903: POM enhancements
Posted by GitBox <gi...@apache.org>.
ppalaga merged pull request #903: POM enhancements
URL: https://github.com/apache/camel-quarkus/pull/903
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on issue #903: POM enhancements
Posted by GitBox <gi...@apache.org>.
ppalaga commented on issue #903: POM enhancements
URL: https://github.com/apache/camel-quarkus/pull/903#issuecomment-600717748
> Do we want to wait for the CI?
Actually, we should, because I also rebased.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on issue #903: POM enhancements
Posted by GitBox <gi...@apache.org>.
ppalaga commented on issue #903: POM enhancements
URL: https://github.com/apache/camel-quarkus/pull/903#issuecomment-600717345
149d0da removed the revert to maven-surefire-plugin.version 3.0.0-M4
Do we want to wait for the CI?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] jamesnetherton commented on a change in pull
request #903: POM enhancements
Posted by GitBox <gi...@apache.org>.
jamesnetherton commented on a change in pull request #903: POM enhancements
URL: https://github.com/apache/camel-quarkus/pull/903#discussion_r394394461
##########
File path: pom.xml
##########
@@ -84,8 +84,7 @@
<maven-source-plugin.version>3.1.0</maven-source-plugin.version>
<maven-assembly-plugin.version>3.1.1</maven-assembly-plugin.version>
<maven-dependency-plugin.version>3.1.1</maven-dependency-plugin.version>
- <!-- NOTE: We pin to this version due to https://github.com/apache/camel-quarkus/issues/723 -->
- <maven-surefire-plugin.version>2.22.2</maven-surefire-plugin.version>
+ <maven-surefire-plugin.version>3.0.0-M4</maven-surefire-plugin.version>
Review comment:
I'm not convinced all of the issues are fixed.
Run `NoDefaultServletTest` (You'll need to remove `@Disabled`) and the test passes with 3.x. Run it with 2.x and it'll fail.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #903:
POM enhancements
Posted by GitBox <gi...@apache.org>.
ppalaga commented on a change in pull request #903: POM enhancements
URL: https://github.com/apache/camel-quarkus/pull/903#discussion_r394457738
##########
File path: pom.xml
##########
@@ -84,8 +84,7 @@
<maven-source-plugin.version>3.1.0</maven-source-plugin.version>
<maven-assembly-plugin.version>3.1.1</maven-assembly-plugin.version>
<maven-dependency-plugin.version>3.1.1</maven-dependency-plugin.version>
- <!-- NOTE: We pin to this version due to https://github.com/apache/camel-quarkus/issues/723 -->
- <maven-surefire-plugin.version>2.22.2</maven-surefire-plugin.version>
+ <maven-surefire-plugin.version>3.0.0-M4</maven-surefire-plugin.version>
Review comment:
That would mean that https://github.com/quarkusio/quarkus/issues/7203 is not fully fixed? Let me remove the commit then.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services