[GitHub] [drill] vvysotskyi commented on a change in pull request #1695: DRILL-7103: Incorrect conversion to integer in BsonRecordReader#writeTimeStamp

[GitBox <gi...@apache.org>]

vvysotskyi commented on a change in pull request #1695: DRILL-7103: Incorrect conversion to integer in BsonRecordReader#writeTimeStamp
URL: https://github.com/apache/drill/pull/1695#discussion_r265911539
 
 

 ##########
 File path: exec/java-exec/src/test/java/org/apache/drill/exec/store/bson/TestBsonRecordReader.java
 ##########
 @@ -88,6 +88,17 @@ public void testTimeStampType() throws IOException {
     assertEquals(1000000l, mapReader.reader("ts").readLocalDateTime().atZone(ZoneOffset.systemDefault()).toInstant().toEpochMilli());
   }
 
+  @Test
+  public void testTimeStampType_now() throws IOException {
 
 Review comment:
   Looks like this is almost the same test as the test before. Can they both be combined, for example, we can write two records (or more) into `BsonDocument`. Also, please use a literal instead of `System.currentTimeMillis()`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services