You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Mark Chu-Carroll <mc...@twopensource.com> on 2014/10/02 17:59:12 UTC
Review Request 26270: Make the client invocation code actually use
the exit codes returned by the client.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26270/
-----------------------------------------------------------
Review request for Aurora, David McLaughlin and Zameer Manji.
Bugs: aurora-781
https://issues.apache.org/jira/browse/aurora-781
Repository: aurora
Description
-------
Fix multiple errors involving bindings, and fix result codes.
- Cause an error to be raised by an unresolved binding in a configuration file.
- Fix incorrect structuring of processed bindings.
- Add a test to confirm that unbound parameters generate errors.
While I'm in the code, also fix a problem where result codes aren't returned correctly
to the shell.
Diffs
-----
src/main/python/apache/aurora/client/cli/client.py 0cb69448cd24372067ac845eca5862bc3d3a46a9
src/main/python/apache/aurora/client/cli/context.py 102d20797816788361dfdac450aac9fb8e6fbc28
src/main/python/apache/aurora/client/cli/options.py c2d422ac2bc82fc387596e93040b49f722f8310f
src/main/python/apache/aurora/client/cli/standalone_client.py 30d8f750559b7811d66760741905fa8adf80fd1f
src/test/python/apache/aurora/client/cli/test_create.py 31fa56f5edcfc97903725ab27ccc12c6a8f39ffc
src/test/python/apache/aurora/client/cli/util.py a50b83c571390374975accf75e31f392dbdaaa04
Diff: https://reviews.apache.org/r/26270/diff/
Testing
-------
Unit tests:
- verified that tests fail if the binding code is disabled, but pass with in on.
- added a new unit test to check that unresolved bindings generate an error.
Thanks,
Mark Chu-Carroll
Re: Review Request 26270: Fix multiple errors involving bindings,
and fix result codes.
Posted by David McLaughlin <da...@dmclaughlin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26270/#review55239
-----------------------------------------------------------
Ship it!
Ship It!
- David McLaughlin
On Oct. 2, 2014, 6:24 p.m., Mark Chu-Carroll wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26270/
> -----------------------------------------------------------
>
> (Updated Oct. 2, 2014, 6:24 p.m.)
>
>
> Review request for Aurora, David McLaughlin and Zameer Manji.
>
>
> Bugs: aurora-781
> https://issues.apache.org/jira/browse/aurora-781
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Fix multiple errors involving bindings, and fix result codes.
>
> - Cause an error to be raised by an unresolved binding in a configuration file.
> - Fix incorrect structuring of processed bindings.
> - Add a test to confirm that unbound parameters generate errors.
>
> While I'm in the code, also fix a problem where result codes aren't returned correctly
> to the shell.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/cli/client.py 0cb69448cd24372067ac845eca5862bc3d3a46a9
> src/main/python/apache/aurora/client/cli/context.py 102d20797816788361dfdac450aac9fb8e6fbc28
> src/main/python/apache/aurora/client/cli/options.py c2d422ac2bc82fc387596e93040b49f722f8310f
> src/main/python/apache/aurora/client/cli/standalone_client.py 30d8f750559b7811d66760741905fa8adf80fd1f
> src/test/python/apache/aurora/client/cli/test_create.py 31fa56f5edcfc97903725ab27ccc12c6a8f39ffc
> src/test/python/apache/aurora/client/cli/util.py a50b83c571390374975accf75e31f392dbdaaa04
>
> Diff: https://reviews.apache.org/r/26270/diff/
>
>
> Testing
> -------
>
> Unit tests:
> - verified that tests fail if the binding code is disabled, but pass with in on.
> - added a new unit test to check that unresolved bindings generate an error.
>
>
> Thanks,
>
> Mark Chu-Carroll
>
>
Re: Review Request 26270: Fix multiple errors involving bindings,
and fix result codes.
Posted by Mark Chu-Carroll <mc...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26270/
-----------------------------------------------------------
(Updated Oct. 2, 2014, 2:24 p.m.)
Review request for Aurora, David McLaughlin and Zameer Manji.
Summary (updated)
-----------------
Fix multiple errors involving bindings, and fix result codes.
Bugs: aurora-781
https://issues.apache.org/jira/browse/aurora-781
Repository: aurora
Description
-------
Fix multiple errors involving bindings, and fix result codes.
- Cause an error to be raised by an unresolved binding in a configuration file.
- Fix incorrect structuring of processed bindings.
- Add a test to confirm that unbound parameters generate errors.
While I'm in the code, also fix a problem where result codes aren't returned correctly
to the shell.
Diffs
-----
src/main/python/apache/aurora/client/cli/client.py 0cb69448cd24372067ac845eca5862bc3d3a46a9
src/main/python/apache/aurora/client/cli/context.py 102d20797816788361dfdac450aac9fb8e6fbc28
src/main/python/apache/aurora/client/cli/options.py c2d422ac2bc82fc387596e93040b49f722f8310f
src/main/python/apache/aurora/client/cli/standalone_client.py 30d8f750559b7811d66760741905fa8adf80fd1f
src/test/python/apache/aurora/client/cli/test_create.py 31fa56f5edcfc97903725ab27ccc12c6a8f39ffc
src/test/python/apache/aurora/client/cli/util.py a50b83c571390374975accf75e31f392dbdaaa04
Diff: https://reviews.apache.org/r/26270/diff/
Testing
-------
Unit tests:
- verified that tests fail if the binding code is disabled, but pass with in on.
- added a new unit test to check that unresolved bindings generate an error.
Thanks,
Mark Chu-Carroll
Re: Review Request 26270: Make the client invocation code actually
use the exit codes returned by the client.
Posted by Zameer Manji <zm...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26270/#review55217
-----------------------------------------------------------
Ship it!
Ship It!
- Zameer Manji
On Oct. 2, 2014, 9:07 a.m., Mark Chu-Carroll wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26270/
> -----------------------------------------------------------
>
> (Updated Oct. 2, 2014, 9:07 a.m.)
>
>
> Review request for Aurora, David McLaughlin and Zameer Manji.
>
>
> Bugs: aurora-781
> https://issues.apache.org/jira/browse/aurora-781
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Fix multiple errors involving bindings, and fix result codes.
>
> - Cause an error to be raised by an unresolved binding in a configuration file.
> - Fix incorrect structuring of processed bindings.
> - Add a test to confirm that unbound parameters generate errors.
>
> While I'm in the code, also fix a problem where result codes aren't returned correctly
> to the shell.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/cli/client.py 0cb69448cd24372067ac845eca5862bc3d3a46a9
> src/main/python/apache/aurora/client/cli/context.py 102d20797816788361dfdac450aac9fb8e6fbc28
> src/main/python/apache/aurora/client/cli/options.py c2d422ac2bc82fc387596e93040b49f722f8310f
> src/main/python/apache/aurora/client/cli/standalone_client.py 30d8f750559b7811d66760741905fa8adf80fd1f
> src/test/python/apache/aurora/client/cli/test_create.py 31fa56f5edcfc97903725ab27ccc12c6a8f39ffc
> src/test/python/apache/aurora/client/cli/util.py a50b83c571390374975accf75e31f392dbdaaa04
>
> Diff: https://reviews.apache.org/r/26270/diff/
>
>
> Testing
> -------
>
> Unit tests:
> - verified that tests fail if the binding code is disabled, but pass with in on.
> - added a new unit test to check that unresolved bindings generate an error.
>
>
> Thanks,
>
> Mark Chu-Carroll
>
>
Re: Review Request 26270: Make the client invocation code actually
use the exit codes returned by the client.
Posted by Mark Chu-Carroll <mc...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26270/
-----------------------------------------------------------
(Updated Oct. 2, 2014, 12:07 p.m.)
Review request for Aurora, David McLaughlin and Zameer Manji.
Changes
-------
Improve error messages, and add output testing.
Bugs: aurora-781
https://issues.apache.org/jira/browse/aurora-781
Repository: aurora
Description
-------
Fix multiple errors involving bindings, and fix result codes.
- Cause an error to be raised by an unresolved binding in a configuration file.
- Fix incorrect structuring of processed bindings.
- Add a test to confirm that unbound parameters generate errors.
While I'm in the code, also fix a problem where result codes aren't returned correctly
to the shell.
Diffs (updated)
-----
src/main/python/apache/aurora/client/cli/client.py 0cb69448cd24372067ac845eca5862bc3d3a46a9
src/main/python/apache/aurora/client/cli/context.py 102d20797816788361dfdac450aac9fb8e6fbc28
src/main/python/apache/aurora/client/cli/options.py c2d422ac2bc82fc387596e93040b49f722f8310f
src/main/python/apache/aurora/client/cli/standalone_client.py 30d8f750559b7811d66760741905fa8adf80fd1f
src/test/python/apache/aurora/client/cli/test_create.py 31fa56f5edcfc97903725ab27ccc12c6a8f39ffc
src/test/python/apache/aurora/client/cli/util.py a50b83c571390374975accf75e31f392dbdaaa04
Diff: https://reviews.apache.org/r/26270/diff/
Testing
-------
Unit tests:
- verified that tests fail if the binding code is disabled, but pass with in on.
- added a new unit test to check that unresolved bindings generate an error.
Thanks,
Mark Chu-Carroll