You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Denis Cabasson (JIRA)" <ji...@codehaus.org> on 2007/07/17 16:06:13 UTC

[jira] Created: (MSITE-244) Relative paths are loosing their query parts

Relative paths are loosing their query parts
--------------------------------------------

                 Key: MSITE-244
                 URL: http://jira.codehaus.org/browse/MSITE-244
             Project: Maven 2.x Site Plugin
          Issue Type: Bug
    Affects Versions: 2.0-beta-6
         Environment: Windows, French Locale, Maven 2.0.6, Site plugin maven-site-plugin-2.0-beta-6-20070716.231146-1
            Reporter: Denis Cabasson
         Attachments: MSITE-test-case.zip

Urls are compared to project url and when necessary are transformed to relative URLs.

In the process those trimmed url loose their query part.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MSITE-244) Relative paths are loosing their query parts

Posted by "Denis Cabasson (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MSITE-244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_102486 ] 

Denis Cabasson commented on MSITE-244:
--------------------------------------

Test case explained :

Just run a mvn site from the base directory.

in the generated target/site folder, the project-info.html file reads 
{quote}
<h5>Menu1</h5>
            <ul>
              
    <li class="none">
                    <a href="index.html">Relative link with Query Part</a>
          </li>
{quote}

When it should read :
<a href="index.html{color:red}?var=foo&amp;var2=bar{color}">Relative link with Query Part</a>

> Relative paths are loosing their query parts
> --------------------------------------------
>
>                 Key: MSITE-244
>                 URL: http://jira.codehaus.org/browse/MSITE-244
>             Project: Maven 2.x Site Plugin
>          Issue Type: Bug
>    Affects Versions: 2.0-beta-6
>         Environment: Windows, French Locale, Maven 2.0.6, Site plugin maven-site-plugin-2.0-beta-6-20070716.231146-1
>            Reporter: Denis Cabasson
>         Attachments: MSITE-test-case.zip
>
>
> Urls are compared to project url and when necessary are transformed to relative URLs.
> In the process those trimmed url loose their query part.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (MSITE-244) Relative paths are losing their query parts

Posted by "Paul Benedict (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MSITE-244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Paul Benedict updated MSITE-244:
--------------------------------

    Summary: Relative paths are losing their query parts  (was: Relative paths are loosing their query parts)

> Relative paths are losing their query parts
> -------------------------------------------
>
>                 Key: MSITE-244
>                 URL: http://jira.codehaus.org/browse/MSITE-244
>             Project: Maven 2.x Site Plugin
>          Issue Type: Bug
>          Components: relative links
>    Affects Versions: 2.0-beta-6
>         Environment: Windows, French Locale, Maven 2.0.6, Site plugin maven-site-plugin-2.0-beta-6-20070716.231146-1
>            Reporter: Denis Cabasson
>             Fix For: 2.1.1
>
>         Attachments: MSITE-test-case.zip
>
>
> Urls are compared to project url and when necessary are transformed to relative URLs.
> In the process those trimmed url loose their query part.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Closed: (MSITE-244) Relative paths are losing their query parts

Posted by "Lukas Theussl (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MSITE-244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lukas Theussl closed MSITE-244.
-------------------------------

       Resolution: Fixed
    Fix Version/s: 2.3
         Assignee: Lukas Theussl

Fixed with DOXIASITETOOLS-49

> Relative paths are losing their query parts
> -------------------------------------------
>
>                 Key: MSITE-244
>                 URL: http://jira.codehaus.org/browse/MSITE-244
>             Project: Maven 2.x and 3.x Site Plugin
>          Issue Type: Bug
>          Components: relative links
>    Affects Versions: 2.0-beta-6
>         Environment: Windows, French Locale, Maven 2.0.6, Site plugin maven-site-plugin-2.0-beta-6-20070716.231146-1
>            Reporter: Denis Cabasson
>            Assignee: Lukas Theussl
>             Fix For: 2.3
>
>         Attachments: MSITE-test-case.zip
>
>
> Urls are compared to project url and when necessary are transformed to relative URLs.
> In the process those trimmed url loose their query part.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MSITE-244) Relative paths are loosing their query parts

Posted by "Denis Cabasson (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MSITE-244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_102487 ] 

Denis Cabasson commented on MSITE-244:
--------------------------------------

fix tip (no time to provide the full patch yet) :

[AbstractSiteMojo|http://svn.apache.org/viewvc/maven/plugins/trunk/maven-site-plugin/src/main/java/org/apache/maven/plugins/site/AbstractSiteMojo.java?revision=556745&view=markup]#getRelativePath is only working on the path part of the url.

The query part should be appended to the generated relative URL.



> Relative paths are loosing their query parts
> --------------------------------------------
>
>                 Key: MSITE-244
>                 URL: http://jira.codehaus.org/browse/MSITE-244
>             Project: Maven 2.x Site Plugin
>          Issue Type: Bug
>    Affects Versions: 2.0-beta-6
>         Environment: Windows, French Locale, Maven 2.0.6, Site plugin maven-site-plugin-2.0-beta-6-20070716.231146-1
>            Reporter: Denis Cabasson
>         Attachments: MSITE-test-case.zip
>
>
> Urls are compared to project url and when necessary are transformed to relative URLs.
> In the process those trimmed url loose their query part.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MSITE-244) Relative paths are loosing their query parts

Posted by "John Allen (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MSITE-244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_102621 ] 

John Allen commented on MSITE-244:
----------------------------------

You're not wrong. 

> Relative paths are loosing their query parts
> --------------------------------------------
>
>                 Key: MSITE-244
>                 URL: http://jira.codehaus.org/browse/MSITE-244
>             Project: Maven 2.x Site Plugin
>          Issue Type: Bug
>    Affects Versions: 2.0-beta-6
>         Environment: Windows, French Locale, Maven 2.0.6, Site plugin maven-site-plugin-2.0-beta-6-20070716.231146-1
>            Reporter: Denis Cabasson
>         Attachments: MSITE-test-case.zip
>
>
> Urls are compared to project url and when necessary are transformed to relative URLs.
> In the process those trimmed url loose their query part.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MSITE-244) Relative paths are loosing their query parts

Posted by "Lukas Theussl (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MSITE-244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=185367#action_185367 ] 

Lukas Theussl commented on MSITE-244:
-------------------------------------

The description of this issue is not quite correct. The query part is is preserved if you really use a relative link like

{code:xml}
<item name="Relative link with Query Part" href="index.html?var=foo&amp;var2=bar" />
{code}

whereas is gets lost if you use

{code:xml}
<item name="Absolute link with Query Part" href="http://maven.apache.org/index.html?var=foo&amp;var2=bar" />
{code}

(and have <url>http://maven.apache.org/</url> in your pom). So the question is why you would want to link to a page within your site using an absolute link?

> Relative paths are loosing their query parts
> --------------------------------------------
>
>                 Key: MSITE-244
>                 URL: http://jira.codehaus.org/browse/MSITE-244
>             Project: Maven 2.x Site Plugin
>          Issue Type: Bug
>          Components: relative links
>    Affects Versions: 2.0-beta-6
>         Environment: Windows, French Locale, Maven 2.0.6, Site plugin maven-site-plugin-2.0-beta-6-20070716.231146-1
>            Reporter: Denis Cabasson
>             Fix For: 2.1
>
>         Attachments: MSITE-test-case.zip
>
>
> Urls are compared to project url and when necessary are transformed to relative URLs.
> In the process those trimmed url loose their query part.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (MSITE-244) Relative paths are losing their query parts

Posted by "Dennis Lundberg (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MSITE-244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dennis Lundberg updated MSITE-244:
----------------------------------

    Fix Version/s:     (was: 2.1.1)

> Relative paths are losing their query parts
> -------------------------------------------
>
>                 Key: MSITE-244
>                 URL: http://jira.codehaus.org/browse/MSITE-244
>             Project: Maven 2.x Site Plugin
>          Issue Type: Bug
>          Components: relative links
>    Affects Versions: 2.0-beta-6
>         Environment: Windows, French Locale, Maven 2.0.6, Site plugin maven-site-plugin-2.0-beta-6-20070716.231146-1
>            Reporter: Denis Cabasson
>         Attachments: MSITE-test-case.zip
>
>
> Urls are compared to project url and when necessary are transformed to relative URLs.
> In the process those trimmed url loose their query part.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (MSITE-244) Relative paths are loosing their query parts

Posted by "Dennis Lundberg (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MSITE-244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dennis Lundberg updated MSITE-244:
----------------------------------

    Component/s: relative links

> Relative paths are loosing their query parts
> --------------------------------------------
>
>                 Key: MSITE-244
>                 URL: http://jira.codehaus.org/browse/MSITE-244
>             Project: Maven 2.x Site Plugin
>          Issue Type: Bug
>          Components: relative links
>    Affects Versions: 2.0-beta-6
>         Environment: Windows, French Locale, Maven 2.0.6, Site plugin maven-site-plugin-2.0-beta-6-20070716.231146-1
>            Reporter: Denis Cabasson
>         Attachments: MSITE-test-case.zip
>
>
> Urls are compared to project url and when necessary are transformed to relative URLs.
> In the process those trimmed url loose their query part.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (MSITE-244) Relative paths are losing their query parts

Posted by "Dennis Lundberg (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MSITE-244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dennis Lundberg updated MSITE-244:
----------------------------------

    Fix Version/s: 3.0-beta-4

> Relative paths are losing their query parts
> -------------------------------------------
>
>                 Key: MSITE-244
>                 URL: http://jira.codehaus.org/browse/MSITE-244
>             Project: Maven 2.x and 3.x Site Plugin
>          Issue Type: Bug
>          Components: relative links
>    Affects Versions: 2.0-beta-6
>         Environment: Windows, French Locale, Maven 2.0.6, Site plugin maven-site-plugin-2.0-beta-6-20070716.231146-1
>            Reporter: Denis Cabasson
>            Assignee: Lukas Theussl
>             Fix For: 2.3, 3.0-beta-4
>
>         Attachments: MSITE-test-case.zip
>
>
> Urls are compared to project url and when necessary are transformed to relative URLs.
> In the process those trimmed url loose their query part.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira