You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "kwin (via GitHub)" <gi...@apache.org> on 2026/03/31 12:26:39 UTC
[PR] Emit file name when exception happens during convert [maven-doxia-converter]
kwin opened a new pull request, #133:
URL: https://github.com/apache/maven-doxia-converter/pull/133
Following this checklist to help us incorporate your
contribution quickly and easily:
- [ ] Your pull request should address just one issue, without pulling in other changes.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
Note that commits might be squashed by a maintainer on merge.
- [ ] Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied.
This may not always be possible but is a best-practice.
- [ ] Run `mvn verify` to make sure basic checks pass.
A more thorough check will be performed on your pull request automatically.
- [ ] You have run the integration tests successfully (`mvn -Prun-its verify`).
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Emit file name when exception happens during convert [maven-doxia-converter]
Posted by "kwin (via GitHub)" <gi...@apache.org>.
kwin merged PR #133:
URL: https://github.com/apache/maven-doxia-converter/pull/133
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Emit file name when exception happens during convert [maven-doxia-converter]
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on code in PR #133:
URL: https://github.com/apache/maven-doxia-converter/pull/133#discussion_r3016289547
##########
src/main/java/org/apache/maven/doxia/DefaultConverter.java:
##########
@@ -357,9 +357,14 @@ public void convert(InputFileWrapper input, OutputFileWrapper output)
+ input.getFormat().getExtension() + " found in directory " + input.getFile());
}
for (File f : files) {
- File relativeOutputDirectory = new File(
- PathTool.getRelativeFilePath(input.getFile().getAbsolutePath(), f.getParent()));
- convert(f, input.getEncoding(), input.getFormat(), output, relativeOutputDirectory);
+ try {
+ File relativeOutputDirectory = new File(
+ PathTool.getRelativeFilePath(input.getFile().getAbsolutePath(), f.getParent()));
+ convert(f, input.getEncoding(), input.getFormat(), output, relativeOutputDirectory);
Review Comment:
`convert` method is also call in line 342
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Emit file name when exception happens during convert [maven-doxia-converter]
Posted by "kwin (via GitHub)" <gi...@apache.org>.
kwin commented on code in PR #133:
URL: https://github.com/apache/maven-doxia-converter/pull/133#discussion_r3016238023
##########
src/main/java/org/apache/maven/doxia/DefaultConverter.java:
##########
@@ -357,9 +357,14 @@ public void convert(InputFileWrapper input, OutputFileWrapper output)
+ input.getFormat().getExtension() + " found in directory " + input.getFile());
}
for (File f : files) {
- File relativeOutputDirectory = new File(
- PathTool.getRelativeFilePath(input.getFile().getAbsolutePath(), f.getParent()));
- convert(f, input.getEncoding(), input.getFormat(), output, relativeOutputDirectory);
+ try {
+ File relativeOutputDirectory = new File(
+ PathTool.getRelativeFilePath(input.getFile().getAbsolutePath(), f.getParent()));
+ convert(f, input.getEncoding(), input.getFormat(), output, relativeOutputDirectory);
+ } catch (Exception e) {
Review Comment:
Not sure what parsers throw (some just runtime exceptions like ISE, IAE, others `ParseException`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Emit file name when exception happens during convert [maven-doxia-converter]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #133:
URL: https://github.com/apache/maven-doxia-converter/pull/133#issuecomment-4250879692
@kwin Please assign appropriate label to PR according to the type of change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Emit file name when exception happens during convert [maven-doxia-converter]
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on code in PR #133:
URL: https://github.com/apache/maven-doxia-converter/pull/133#discussion_r3016225197
##########
src/main/java/org/apache/maven/doxia/DefaultConverter.java:
##########
@@ -357,9 +357,14 @@ public void convert(InputFileWrapper input, OutputFileWrapper output)
+ input.getFormat().getExtension() + " found in directory " + input.getFile());
}
for (File f : files) {
- File relativeOutputDirectory = new File(
- PathTool.getRelativeFilePath(input.getFile().getAbsolutePath(), f.getParent()));
- convert(f, input.getEncoding(), input.getFormat(), output, relativeOutputDirectory);
+ try {
+ File relativeOutputDirectory = new File(
+ PathTool.getRelativeFilePath(input.getFile().getAbsolutePath(), f.getParent()));
+ convert(f, input.getEncoding(), input.getFormat(), output, relativeOutputDirectory);
+ } catch (Exception e) {
Review Comment:
Do we need to catch global exception? Is there a specific exception to catch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Emit file name when exception happens during convert [maven-doxia-converter]
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on code in PR #133:
URL: https://github.com/apache/maven-doxia-converter/pull/133#discussion_r3016298387
##########
src/main/java/org/apache/maven/doxia/DefaultConverter.java:
##########
Review Comment:
Maybe this method should be adjust to always return filename in exeception
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Emit file name when exception happens during convert [maven-doxia-converter]
Posted by "kwin (via GitHub)" <gi...@apache.org>.
kwin commented on code in PR #133:
URL: https://github.com/apache/maven-doxia-converter/pull/133#discussion_r3080973048
##########
src/main/java/org/apache/maven/doxia/DefaultConverter.java:
##########
Review Comment:
Good point, done in https://github.com/apache/maven-doxia-converter/pull/133/commits/f959ef15a6709a8265f26ad8e4d79a7b4d58bbd3
##########
src/main/java/org/apache/maven/doxia/DefaultConverter.java:
##########
@@ -357,9 +357,14 @@ public void convert(InputFileWrapper input, OutputFileWrapper output)
+ input.getFormat().getExtension() + " found in directory " + input.getFile());
}
for (File f : files) {
- File relativeOutputDirectory = new File(
- PathTool.getRelativeFilePath(input.getFile().getAbsolutePath(), f.getParent()));
- convert(f, input.getEncoding(), input.getFormat(), output, relativeOutputDirectory);
+ try {
+ File relativeOutputDirectory = new File(
+ PathTool.getRelativeFilePath(input.getFile().getAbsolutePath(), f.getParent()));
+ convert(f, input.getEncoding(), input.getFormat(), output, relativeOutputDirectory);
Review Comment:
Fixed via https://github.com/apache/maven-doxia-converter/pull/133/commits/f959ef15a6709a8265f26ad8e4d79a7b4d58bbd3.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org