You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "peter-toth (via GitHub)" <gi...@apache.org> on 2024/11/12 09:52:39 UTC
[PR] annotate get_type with recursive [datafusion]
peter-toth opened a new pull request, #13376:
URL: https://github.com/apache/datafusion/pull/13376
## Which issue does this PR close?
Follow-up to https://github.com/apache/datafusion/pull/13310, closes https://github.com/apache/datafusion/issues/9375.
## Rationale for this change
This is a small follow-up change to the previous PR to fix the stack overflow issue in https://github.com/apache/datafusion/issues/9375.
Please note that during the investigation 2 different issues were discovered:
- There was a stack overflow with `debug` build due to `sqlparser`, and this didn't come up with `release` build: https://github.com/apache/datafusion/issues/9375#issuecomment-2469909998.
- And there was a different stack overflow with `release` build: https://github.com/apache/datafusion/issues/9375#issuecomment-2470000115.
This PR fixes only the 2nd issue.
Most likely the 1st issue can also be fixed with stacker/recursive, but the change would be required in https://github.com/apache/datafusion-sqlparser-rs.
## What changes are included in this PR?
This PR annotates `Expr::get_type` with `#[recursive]`
## Are these changes tested?
Yes, with the `blowout2.zip` test provided in the issue description:
```
% cargo run --release -- -f ~/Downloads/blowout2.sql
...
DataFusion CLI v43.0.0
0 row(s) fetched.
Elapsed 0.007 seconds.
+-------+
| count |
+-------+
| 1 |
+-------+
1 row(s) fetched.
Elapsed 0.007 seconds.
+---+
| x |
+---+
| 1 |
+---+
1 row(s) fetched.
Elapsed 1.262 seconds.
```
## Are there any user-facing changes?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Annotate `Expr::get_type()` with recursive [datafusion]
Posted by "findepi (via GitHub)" <gi...@apache.org>.
findepi commented on PR #13376:
URL: https://github.com/apache/datafusion/pull/13376#issuecomment-2480698904
Would we benefit from any Large OR list test to prevent regressions, especially as we write new code or new optimizers?
(eg expression simplification)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Annotate `Expr::get_type()` with recursive [datafusion]
Posted by "peter-toth (via GitHub)" <gi...@apache.org>.
peter-toth commented on PR #13376:
URL: https://github.com/apache/datafusion/pull/13376#issuecomment-2470079609
cc @gruuya, @alamb
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Annotate `Expr::get_type()` with recursive [datafusion]
Posted by "jayzhan211 (via GitHub)" <gi...@apache.org>.
jayzhan211 commented on PR #13376:
URL: https://github.com/apache/datafusion/pull/13376#issuecomment-2472054276
Thanks @peter-toth @gruuya
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Annotate `Expr::get_type()` with recursive [datafusion]
Posted by "jayzhan211 (via GitHub)" <gi...@apache.org>.
jayzhan211 merged PR #13376:
URL: https://github.com/apache/datafusion/pull/13376
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org