[jira] [Commented] (OPENNLP-935) TwoPassDataIndexer should not swallow IOExceptions

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OPENNLP-935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15821137#comment-15821137 ] 

ASF GitHub Bot commented on OPENNLP-935:
----------------------------------------

Github user asfgit closed the pull request at:

    https://github.com/apache/opennlp/pull/52


> TwoPassDataIndexer should not swallow IOExceptions
> --------------------------------------------------
>
>                 Key: OPENNLP-935
>                 URL: https://issues.apache.org/jira/browse/OPENNLP-935
>             Project: OpenNLP
>          Issue Type: Bug
>          Components: Machine Learning
>            Reporter: Joern Kottmann
>            Assignee: Joern Kottmann
>
> The exception should not be caught at all, if there is an IOException it has to be passed up the call stack to the cmd line interface or user code calling some variant of the train methods.
> Note: In the TwoPassDataIndexer the index methods code is duplicated and this should be fixed on both variants.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)