You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@activemq.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2022/11/24 11:13:00 UTC
[jira] [Work logged] (ARTEMIS-4098) AMQP messages missing correlation ID in console
[ https://issues.apache.org/jira/browse/ARTEMIS-4098?focusedWorklogId=828675&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-828675 ]
ASF GitHub Bot logged work on ARTEMIS-4098:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 24/Nov/22 11:12
Start Date: 24/Nov/22 11:12
Worklog Time Spent: 10m
Work Description: gemmellr commented on code in PR #4295:
URL: https://github.com/apache/activemq-artemis/pull/4295#discussion_r1031388599
##########
artemis-protocols/artemis-amqp-protocol/src/test/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPMessageTest.java:
##########
@@ -2285,6 +2287,7 @@ public void testToCompositeDataPropertiesSection() throws Exception {
assertTrue(properties.contains(PROPERTY_MAP_PROPERTIES_PREFIX + "absoluteExpiryTime" + "=" + testExpiryTime));
assertTrue(properties.contains(PROPERTY_MAP_PROPERTIES_PREFIX + "to" + "=" + TEST_TO_ADDRESS));
assertTrue(properties.contains(PROPERTY_MAP_PROPERTIES_PREFIX + "subject" + "=" + testSubject));
+ assertTrue(properties.contains(PROPERTY_MAP_PROPERTIES_PREFIX + "correlationId" + "=" + testCorrelationId));
Review Comment:
This makes the comment below further inaccurate. It already was since the reply-to field was added without any test in https://github.com/apache/activemq-artemis/commit/cbd8df6459b01f816d922efb967800bf020b4e6a
##########
artemis-protocols/artemis-amqp-protocol/src/test/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPMessageTest.java:
##########
@@ -2285,6 +2287,7 @@ public void testToCompositeDataPropertiesSection() throws Exception {
assertTrue(properties.contains(PROPERTY_MAP_PROPERTIES_PREFIX + "absoluteExpiryTime" + "=" + testExpiryTime));
assertTrue(properties.contains(PROPERTY_MAP_PROPERTIES_PREFIX + "to" + "=" + TEST_TO_ADDRESS));
assertTrue(properties.contains(PROPERTY_MAP_PROPERTIES_PREFIX + "subject" + "=" + testSubject));
+ assertTrue(properties.contains(PROPERTY_MAP_PROPERTIES_PREFIX + "correlationId" + "=" + testCorrelationId));
Review Comment:
This makes the comment below it further inaccurate. It already was since the reply-to field was added without any test in https://github.com/apache/activemq-artemis/commit/cbd8df6459b01f816d922efb967800bf020b4e6a
Issue Time Tracking
-------------------
Worklog Id: (was: 828675)
Remaining Estimate: 0h
Time Spent: 10m
> AMQP messages missing correlation ID in console
> -----------------------------------------------
>
> Key: ARTEMIS-4098
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4098
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: AMQP, Web Console
> Reporter: Justin Bertram
> Assignee: Justin Bertram
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)