You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by "Bob Evans (JIRA)" <ji...@apache.org> on 2009/03/11 20:20:50 UTC
[jira] Created: (SHINDIG-971) JsonRpcServlet should set content
type to json in all cases, including gets and error cases.
JsonRpcServlet should set content type to json in all cases, including gets and error cases.
---------------------------------------------------------------------------------------------
Key: SHINDIG-971
URL: https://issues.apache.org/jira/browse/SHINDIG-971
Project: Shindig
Issue Type: Bug
Reporter: Bob Evans
Currently, the JsonRpcServlet only sets the content type in the case of a properly formed post request. It should also do it in the sendError case, and in the GET request method case.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: [jira] Commented: (SHINDIG-971) JsonRpcServlet should set content
type to json in all cases, including gets and error cases.
Posted by Bob Evans <bo...@google.com>.
based on our previous discussion, I wondered about that too, I opted
to leave it the way it was currently specified for the portions where
it was set, but am open to changing it.
Bob
On Wed, Mar 11, 2009 at 5:59 PM, Evan Gilbert (JIRA) <ji...@apache.org> wrote:
>
> [ https://issues.apache.org/jira/browse/SHINDIG-971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12681123#action_12681123 ]
>
> Evan Gilbert commented on SHINDIG-971:
> --------------------------------------
>
> Wondering how people would feel about returning application/javascript instead of application/json?
>
> I've rarely seen application/json used, probably because debugging is very difficult with application/json as most browsers treat the content as a binary file and try to download it.
>
> Application/javascript will also work with JSONP when we enable it.
>
>> JsonRpcServlet should set content type to json in all cases, including gets and error cases.
>> ---------------------------------------------------------------------------------------------
>>
>> Key: SHINDIG-971
>> URL: https://issues.apache.org/jira/browse/SHINDIG-971
>> Project: Shindig
>> Issue Type: Bug
>> Reporter: Bob Evans
>> Attachments: fix-971-bug.patch
>>
>>
>> Currently, the JsonRpcServlet only sets the content type in the case of a properly formed post request. It should also do it in the sendError case, and in the GET request method case.
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>
[jira] Commented: (SHINDIG-971) JsonRpcServlet should set content
type to json in all cases, including gets and error cases.
Posted by "Chris Chabot (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12681124#action_12681124 ]
Chris Chabot commented on SHINDIG-971:
--------------------------------------
there's a lot of live sites who use application/json, patching this in shindig trunk isn't going to change that reality and having different (non-spec-defined) content-types set would only lead to confusion in my opinion
> JsonRpcServlet should set content type to json in all cases, including gets and error cases.
> ---------------------------------------------------------------------------------------------
>
> Key: SHINDIG-971
> URL: https://issues.apache.org/jira/browse/SHINDIG-971
> Project: Shindig
> Issue Type: Bug
> Reporter: Bob Evans
> Attachments: fix-971-bug.patch
>
>
> Currently, the JsonRpcServlet only sets the content type in the case of a properly formed post request. It should also do it in the sendError case, and in the GET request method case.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SHINDIG-971) JsonRpcServlet should set content
type to json in all cases, including gets and error cases.
Posted by "Vincent Siveton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Vincent Siveton updated SHINDIG-971:
------------------------------------
Component/s: Java
> JsonRpcServlet should set content type to json in all cases, including gets and error cases.
> ---------------------------------------------------------------------------------------------
>
> Key: SHINDIG-971
> URL: https://issues.apache.org/jira/browse/SHINDIG-971
> Project: Shindig
> Issue Type: Bug
> Components: Java
> Reporter: Bob Evans
> Attachments: fix-971-bug.patch
>
>
> Currently, the JsonRpcServlet only sets the content type in the case of a properly formed post request. It should also do it in the sendError case, and in the GET request method case.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SHINDIG-971) JsonRpcServlet should set content
type to json in all cases, including gets and error cases.
Posted by "Paul Lindner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Paul Lindner resolved SHINDIG-971.
----------------------------------
Resolution: Fixed
Fix Version/s: trunk
checked into trunk
> JsonRpcServlet should set content type to json in all cases, including gets and error cases.
> ---------------------------------------------------------------------------------------------
>
> Key: SHINDIG-971
> URL: https://issues.apache.org/jira/browse/SHINDIG-971
> Project: Shindig
> Issue Type: Bug
> Components: Java
> Reporter: Bob Evans
> Fix For: trunk
>
> Attachments: fix-971-bug.patch
>
>
> Currently, the JsonRpcServlet only sets the content type in the case of a properly formed post request. It should also do it in the sendError case, and in the GET request method case.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-971) JsonRpcServlet should set content
type to json in all cases, including gets and error cases.
Posted by "Evan Gilbert (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12681123#action_12681123 ]
Evan Gilbert commented on SHINDIG-971:
--------------------------------------
Wondering how people would feel about returning application/javascript instead of application/json?
I've rarely seen application/json used, probably because debugging is very difficult with application/json as most browsers treat the content as a binary file and try to download it.
Application/javascript will also work with JSONP when we enable it.
> JsonRpcServlet should set content type to json in all cases, including gets and error cases.
> ---------------------------------------------------------------------------------------------
>
> Key: SHINDIG-971
> URL: https://issues.apache.org/jira/browse/SHINDIG-971
> Project: Shindig
> Issue Type: Bug
> Reporter: Bob Evans
> Attachments: fix-971-bug.patch
>
>
> Currently, the JsonRpcServlet only sets the content type in the case of a properly formed post request. It should also do it in the sendError case, and in the GET request method case.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SHINDIG-971) JsonRpcServlet should set content
type to json in all cases, including gets and error cases.
Posted by "Bob Evans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bob Evans updated SHINDIG-971:
------------------------------
Attachment: fix-971-bug.patch
> JsonRpcServlet should set content type to json in all cases, including gets and error cases.
> ---------------------------------------------------------------------------------------------
>
> Key: SHINDIG-971
> URL: https://issues.apache.org/jira/browse/SHINDIG-971
> Project: Shindig
> Issue Type: Bug
> Reporter: Bob Evans
> Attachments: fix-971-bug.patch
>
>
> Currently, the JsonRpcServlet only sets the content type in the case of a properly formed post request. It should also do it in the sendError case, and in the GET request method case.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.