You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@logging.apache.org by rg...@apache.org on 2015/10/04 08:24:34 UTC

[25/50] logging-log4j2 git commit: Refactor toString() impl. into new method getFullName().

Refactor toString() impl. into new method getFullName().


Project: http://git-wip-us.apache.org/repos/asf/logging-log4j2/repo
Commit: http://git-wip-us.apache.org/repos/asf/logging-log4j2/commit/8e397a17
Tree: http://git-wip-us.apache.org/repos/asf/logging-log4j2/tree/8e397a17
Diff: http://git-wip-us.apache.org/repos/asf/logging-log4j2/diff/8e397a17

Branch: refs/heads/LOG4J2-1136
Commit: 8e397a17a3bdb7efbcd4a010dcde240a1f976246
Parents: ae353a2
Author: ggregory <gg...@apache.org>
Authored: Thu Oct 1 11:36:00 2015 -0700
Committer: Ralph Goers <rg...@nextiva.com>
Committed: Sat Oct 3 23:08:05 2015 -0700

----------------------------------------------------------------------
 .../org/apache/logging/log4j/MarkerManager.java   | 18 +++++++++++-------
 1 file changed, 11 insertions(+), 7 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/8e397a17/log4j-api/src/main/java/org/apache/logging/log4j/MarkerManager.java
----------------------------------------------------------------------
diff --git a/log4j-api/src/main/java/org/apache/logging/log4j/MarkerManager.java b/log4j-api/src/main/java/org/apache/logging/log4j/MarkerManager.java
index 320eb84..d0605ed 100644
--- a/log4j-api/src/main/java/org/apache/logging/log4j/MarkerManager.java
+++ b/log4j-api/src/main/java/org/apache/logging/log4j/MarkerManager.java
@@ -226,6 +226,16 @@ public final class MarkerManager {
             return this;
         }
 
+        public String getFullName() {
+            // FIXME: might want to use an initial capacity; the default is 16 (or str.length() + 16)
+            final StringBuilder sb = new StringBuilder(name);
+            final Marker[] localParents = parents;
+            if (localParents != null) {
+                addParentInfo(sb, localParents);
+            }
+            return sb.toString();
+        }
+
         @Override
         public String getName() {
             return this.name;
@@ -366,13 +376,7 @@ public final class MarkerManager {
 
         @Override
         public String toString() {
-            // FIXME: might want to use an initial capacity; the default is 16 (or str.length() + 16)
-            final StringBuilder sb = new StringBuilder(name);
-            final Marker[] localParents = parents;
-            if (localParents != null) {
-                addParentInfo(sb, localParents);
-            }
-            return sb.toString();
+            return getFullName();
         }
 
         private static void addParentInfo(final StringBuilder sb, final Marker... parents) {