You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2019/12/26 00:58:36 UTC

[GitHub] [incubator-hudi] SteNicholas edited a comment on issue #1136: [MINOR]Optimize hudi-cli module

SteNicholas edited a comment on issue #1136: [MINOR]Optimize hudi-cli module
URL: https://github.com/apache/incubator-hudi/pull/1136#issuecomment-568942473
 
 
   > `hudi-cli` as it is is weak on unit tests.. Do you want to first take up that task on the current master branch.. that way we would know how/if large changes like these affect the functionality..
   > 
   > Your changes may be fine. but I am just saying it would be good to first add some tests to the module.. (again not a problem of this PR, but something that affects it)
   
   @vinothchandar My original thought was that optimizing the code of hudi-cli, never consider the unit tests.  I would like to first take up that task on the current master branch.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services