You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@carbondata.apache.org by GitBox <gi...@apache.org> on 2020/05/11 06:36:25 UTC

[GitHub] [carbondata] niuge01 commented on a change in pull request #3755: [CARBONDATA-3814]Remove dead code and refactor MV events

niuge01 commented on a change in pull request #3755:
URL: https://github.com/apache/carbondata/pull/3755#discussion_r422812384



##########
File path: integration/spark/src/main/scala/org/apache/carbondata/events/Events.scala
##########
@@ -195,7 +195,7 @@ trait CreateCarbonRelationEventInfo {
  */
 trait MVEventsInfo {
   val sparkSession: SparkSession
-  val storePath: String
+  val systemDirectoryPath: String

Review comment:
       The field name changed, but i can not found any code which used the field has be changed, it's will be OK？




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org